Repository navigation
Commit 42b60b9
fix(service-settings): Company legal-name help no longer points to an organization name under Branding (#25225)
<!-- claude-projects-attribution: {"github_login":"os-sales"} -->
_Requested by **Sales** · [project
thread](https://claude.ai/code/project/chan_01D5bWFY3rFzgJcytD5gD4Uu?thread=cmsg_01D5bWFY3rFzgJcytD5gD4UuACdPWFJTLDcTrByFCHLzqb)_
Fixes #24987
Clause-②: no
Metadata-protocol: none
## What changed
The Company page's Legal name help said the legal name "may differ from
the organization name set under Branding". That is false since the
Branding rework: Branding's `workspace_name` is the product name, and
Branding is not offered at all under the `group` and `isolated`
postures, while Company is offered on every posture.
- `company.manifest.ts`: the `legal_name` description now reads
"Registered legal name of the organization, as it appears on contracts
and invoices." The header comment's description of `branding`
("public-facing workspace name / logo / theme") is replaced by what
Branding actually offers (product name, logo, accent colour; `single`
posture only). Nothing in the file referenced `theme_mode` by name.
- `translations/en.ts`, `zh-CN.ts`, `ja-JP.ts`, `es-ES.ts`: the
`legal_name` help carries the same sentence in each locale. These four
bundles are hand-written, not generated (`*.generated.ts` does not exist
in this package), so they were edited by hand.
- `.changeset/24987-legal-name-help.md`: one `patch` changeset for
`@objectstack/service-settings`.
Copy only; no key, value or behaviour changes.
## Verification
- Premise re-checked on current main (123ff6f): all five false strings
still present, nowhere else in the repo (`git grep` over the English,
Chinese, Japanese and Spanish spellings).
- `pnpm --filter @objectstack/service-settings test` and `typecheck`
after building the dependency closure: 57/57 files, 970/970 tests,
typecheck exit 0 (head 7aa8df0).
- `dispatch-gates --commands`: 60 derived families, 58 run with exit 0,
2 NOT MEASURED (exit 3, prerequisite not met):
`check-plugin-teardown-shape.mjs --self-test` needs a deeper clone
(shallow checkout), and `check:dual-build-cjs-loads` needs a full-repo
build. Both are checker-level; CI runs them on a full checkout.
## Acceptance notes
None.
---
_Generated by [Claude
Code](https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy)_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent f2ade4a commit 42b60b9
6 files changed
Lines changed: 23 additions & 11 deletions
File tree
- .changeset
- packages/services/service-settings/src
- manifests
- translations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | | - | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
| 306 | + | |
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
| 306 | + | |
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| |||
0 commit comments