Skip to content

Commit 42b60b9

Browse files
fix(service-settings): Company legal-name help no longer points to an organization name under Branding (#25225)
<!-- claude-projects-attribution: {"github_login":"os-sales"} --> _Requested by **Sales** · [project thread](https://claude.ai/code/project/chan_01D5bWFY3rFzgJcytD5gD4Uu?thread=cmsg_01D5bWFY3rFzgJcytD5gD4UuACdPWFJTLDcTrByFCHLzqb)_ Fixes #24987 Clause-②: no Metadata-protocol: none ## What changed The Company page's Legal name help said the legal name "may differ from the organization name set under Branding". That is false since the Branding rework: Branding's `workspace_name` is the product name, and Branding is not offered at all under the `group` and `isolated` postures, while Company is offered on every posture. - `company.manifest.ts`: the `legal_name` description now reads "Registered legal name of the organization, as it appears on contracts and invoices." The header comment's description of `branding` ("public-facing workspace name / logo / theme") is replaced by what Branding actually offers (product name, logo, accent colour; `single` posture only). Nothing in the file referenced `theme_mode` by name. - `translations/en.ts`, `zh-CN.ts`, `ja-JP.ts`, `es-ES.ts`: the `legal_name` help carries the same sentence in each locale. These four bundles are hand-written, not generated (`*.generated.ts` does not exist in this package), so they were edited by hand. - `.changeset/24987-legal-name-help.md`: one `patch` changeset for `@objectstack/service-settings`. Copy only; no key, value or behaviour changes. ## Verification - Premise re-checked on current main (123ff6f): all five false strings still present, nowhere else in the repo (`git grep` over the English, Chinese, Japanese and Spanish spellings). - `pnpm --filter @objectstack/service-settings test` and `typecheck` after building the dependency closure: 57/57 files, 970/970 tests, typecheck exit 0 (head 7aa8df0). - `dispatch-gates --commands`: 60 derived families, 58 run with exit 0, 2 NOT MEASURED (exit 3, prerequisite not met): `check-plugin-teardown-shape.mjs --self-test` needs a deeper clone (shallow checkout), and `check:dual-build-cjs-loads` needs a full-repo build. Both are checker-level; CI runs them on a full checkout. ## Acceptance notes None. --- _Generated by [Claude Code](https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016g7nYP9wdNx1GDa5XDr7Uy --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent f2ade4a commit 42b60b9

6 files changed

Lines changed: 23 additions & 11 deletions

File tree

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
'@objectstack/service-settings': patch
3+
---
4+
5+
fix(service-settings): Setup → Company → Legal name help no longer points to an organization name under Branding
6+
7+
Clause-②: no
8+
9+
Metadata-protocol: none
10+
11+
The `legal_name` help in the Company settings page (the manifest description and the `en`, `zh-CN`, `ja-JP` and `es-ES` bundles) said the legal name "may differ from the organization name set under Branding". Branding's workspace name is the product name, not an organization name, and the Branding page is not offered at all under the `group` and `isolated` postures, where Company is. The help now reads "Registered legal name of the organization, as it appears on contracts and invoices." in every locale. Copy only; no key, value or behaviour changes.

‎packages/services/service-settings/src/manifests/company.manifest.ts‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@ import type { SettingsManifest } from '@objectstack/spec/system';
55
/**
66
* Company — the workspace's legal organization identity.
77
*
8-
* Distinct from `branding` (the public-facing workspace name / logo / theme):
9-
* this is the **legal entity** — registered name, address, tax IDs, and the
10-
* primary contact. Downstream consumers are invoices/receipts, email footers
11-
* (CAN-SPAM requires a physical postal address), contracts, and compliance
12-
* exports. Benchmarked against Salesforce "Company Information" and Stripe's
13-
* business profile.
8+
* Distinct from `branding` (the product name / logo / accent colour the console
9+
* shows; not offered under the walled `group` / `isolated` postures): this is
10+
* the **legal entity** — registered name, address, tax IDs, and the primary
11+
* contact. Downstream consumers are invoices/receipts, email footers (CAN-SPAM
12+
* requires a physical postal address), contracts, and compliance exports.
13+
* Benchmarked against Salesforce "Company Information" and Stripe's business
14+
* profile.
1415
*
1516
* Scope is `tenant`: one org per physical tenant (ADR-0002).
1617
*/
@@ -30,7 +31,7 @@ export const companySettingsManifest: SettingsManifest = {
3031
{ type: 'group', id: 'identity', label: 'Identity', required: false },
3132
{
3233
type: 'text', key: 'legal_name', label: 'Legal name', required: false,
33-
description: 'Registered legal name of the organization (may differ from the organization name set under Branding).',
34+
description: 'Registered legal name of the organization, as it appears on contracts and invoices.',
3435
maxLength: 200,
3536
},
3637
{

‎packages/services/service-settings/src/translations/en.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export const en: PlatformTranslationData = {
9898
contact: { title: 'Contact' },
9999
},
100100
keys: {
101-
legal_name: { label: 'Legal name', help: 'Registered legal name (may differ from the organization name set under Branding).' },
101+
legal_name: { label: 'Legal name', help: 'Registered legal name of the organization, as it appears on contracts and invoices.' },
102102
registration_number: { label: 'Registration number', help: 'Company registration / incorporation number (e.g. EIN).' },
103103
tax_id: { label: 'Tax / VAT ID', help: 'Shown on invoices (e.g. VAT, GST, ABN).' },
104104
address_line1: { label: 'Address line 1' },

‎packages/services/service-settings/src/translations/es-ES.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ export const esES: PlatformTranslationData = {
303303
contact: { title: 'Contacto' },
304304
},
305305
keys: {
306-
legal_name: { label: 'Razón social', help: 'Nombre legal registrado de la organización (puede diferir del nombre de la organización indicado en Marca).' },
306+
legal_name: { label: 'Razón social', help: 'Nombre legal registrado de la organización, tal como aparece en contratos y facturas.' },
307307
registration_number: { label: 'Número de registro', help: 'Número de registro / constitución de la empresa (p. ej. EIN, n.º de sociedad).' },
308308
tax_id: { label: 'ID fiscal / IVA', help: 'Identificador fiscal que aparece en las facturas (p. ej. IVA, GST, ABN).' },
309309
address_line1: { label: 'Dirección línea 1' },

‎packages/services/service-settings/src/translations/ja-JP.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ export const jaJP: PlatformTranslationData = {
303303
contact: { title: '連絡先' },
304304
},
305305
keys: {
306-
legal_name: { label: '登記名', help: '組織の登記上の正式名称(「ブランディング」の組織名と異なる場合があります)。' },
306+
legal_name: { label: '登記名', help: '契約書や請求書に記載される、組織の登記上の正式名称。' },
307307
registration_number: { label: '登記番号', help: '会社の登記 / 設立番号(例:EIN、会社番号)。' },
308308
tax_id: { label: '税務 / VAT ID', help: '請求書に表示される税務識別番号(例:VAT、GST、ABN)。' },
309309
address_line1: { label: '住所 1' },

‎packages/services/service-settings/src/translations/zh-CN.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ export const zhCN: PlatformTranslationData = {
130130
contact: { title: '联系方式' },
131131
},
132132
keys: {
133-
legal_name: { label: '法定名称', help: '注册的法定名称(可能与「品牌」中的组织名称不同)。' },
133+
legal_name: { label: '法定名称', help: '组织的注册法定名称,用于合同和发票。' },
134134
registration_number: { label: '注册号', help: '公司注册/工商登记号(如 EIN、统一社会信用代码)。' },
135135
tax_id: { label: '税号 / VAT', help: '发票上显示的税务标识(如 VAT、GST、ABN)。' },
136136
address_line1: { label: '地址行 1' },

0 commit comments

Comments
 (0)