You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3c557e2
Browse filesBrowse the repository at this point in the historyBrowse files
fix(service-analytics): translate select dimension option labels on dataset charts (#17061)
* fix(service-analytics): translate select dimension option labels on dataset charts
A dataset's select-field dimension rendered its option label straight out of
authored field metadata (opt.label), which is never locale-aware — the
option's label is always the author's own-language text
(SelectOptionSchema.label is a plain string, never an inline locale map). A
dotted cross-object dimension (field: 'contract.direction') was unaffected
because a relationship-path field name never matches a key in the base
object's own field map, so resolveDimensionLabels skips it entirely before
either the select or lookup branch runs.
DimensionLabelDeps gains one new optional capability, translateSelectOptions,
wired in plugin.ts by calling the existing translateObject
(@objectstack/spec/system) against the deployment's i18n bundle -- the same
translator GET /meta/object/:name already uses, so a chart's category labels
now match what the list grid renders for the identical field. No i18n
service configured falls back to exactly today's authored-label behaviour.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012zTkyNHJ7TkuN2oXtP5x37
* changeset(service-analytics): regrade to minor -- new key on the published DimensionLabelDeps
DimensionLabelDeps is re-exported wholesale from index.ts, so translateSelectOptions is a new
key on a published exported type -- the mechanical floor for clause 2 regardless of whether
the key is optional. Backward compatible (additive, no removed/renamed key, no wire-shape
change), so minor rather than major.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012zTkyNHJ7TkuN2oXtP5x37
---------
Co-authored-by: Claude <noreply@anthropic.com>
it('#16773 — a same-object select dimension renders the LOCALIZED option label end to end when the plugin bridge wires translateSelectOptions',async()=>{
0 commit comments