Skip to content

Commit 39caaea

Browse files
committed
test(dogfood): name the settledWhen fault warning by its real route
isDeadlineSettled passes no warnOnError, so evalRowPredicate hands the predicate to evalFieldPredicate, and a fault is warned by warnPredicateFailure, not warnEvalError. Spell the chain through evalFieldPredicate in the cel-field-deadline-settled enforcement cell. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGufzgGEj5Qdn1KEGPUrU8
1 parent 1e5831a commit 39caaea

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎packages/qa/dogfood/test/expression-conformance.ledger.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ export const EXPRESSION_SURFACE: ExprSurface[] = [
227227
summary: "a date / datetime deadline's settle predicate (Field.settledWhen) — display only",
228228
dialect: 'cel', mode: 'interpret', state: 'enforced', failPolicy: 'fail-soft-log',
229229
enforcement:
230-
'console (ui/) isDeadlineSettled (core/evaluator/deadlineSettled.ts) → evalRowPredicate → @objectstack/formula celEngine (interpret), evaluated per record with the row bound as `record`, by every host that draws a date cell beside a row (grid, list, gallery, kanban, tree, the record detail sections and the approval snapshot); the verdict reaches the date / datetime cell as `deadlineSettled`, and a settled deadline paints no overdue wording and no overdue colour. A predicate that faults is logged once (warnEvalError) and answers NOT settled, so the deadline shows as it does without the key. Display only: nothing on the write path reads it. Judged at authoring by lint\'s field-rule pass (`validate-expressions.ts`) as `visibleWhen` is',
230+
'console (ui/) isDeadlineSettled (core/evaluator/deadlineSettled.ts) → evalRowPredicate → evalFieldPredicate (core/evaluator/fieldRules.ts) → @objectstack/formula celEngine (interpret), evaluated per record with the row bound as `record`, by every host that draws a date cell beside a row (grid, list, gallery, kanban, tree, the record detail sections and the approval snapshot); the verdict reaches the date / datetime cell as `deadlineSettled`, and a settled deadline paints no overdue wording and no overdue colour. A predicate that faults is logged once per predicate text (warnPredicateFailure, fieldRules.ts: no `warnOnError` is passed, so evalRowPredicate takes the evalFieldPredicate route) and answers NOT settled, so the deadline shows as it does without the key. Display only: nothing on the write path reads it. Judged at authoring by lint\'s field-rule pass (`validate-expressions.ts`) as `visibleWhen` is',
231231
covers: ['data/field.zod.ts:FieldSchema.settledWhen'],
232232
},
233233
{

0 commit comments

Comments
 (0)