Skip to content

Commit 380124a

Browse files
committed
test(plugin-auth): the ordering pin's resolution note no longer says service-settings is not a dependency
The seeded-boot pin made @objectstack/service-settings a devDependency, aliased to src, so the note's "not a dependency ... would force a new registry entry" became false. The stub's own justification (resolvePluginOrder reads only names and declarations) stands; the note now points at the pin that composes the real plugin. Claude-Session: https://claude.ai/code/session_01WkL6Eijt432S1Y7ekb6ovQ Co-authored-by: Claude <noreply@anthropic.com>
1 parent b67e95f commit 380124a

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

‎packages/plugins/plugin-auth/src/auth-settings-ordering.pin.test.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,13 @@
5353
* subject.
5454
*
5555
* The settings plugin is a NAME-ONLY stub rather than the real
56-
* `SettingsServicePlugin`: `@objectstack/service-settings` is not a dependency
57-
* of `@objectstack/plugin-auth`, and adding one so a test could import it
58-
* would both create a workspace edge that exists for nothing else and force a
59-
* new entry into the shrink-only registry above. `resolvePluginOrder` reads
60-
* only the `OrderablePlugin` surface — `name`, `dependencies`,
61-
* `optionalDependencies` — and the property under test is `AuthPlugin`'s
62-
* declaration, so the stub is the whole of what the resolver would see.
56+
* `SettingsServicePlugin`: `resolvePluginOrder` reads only the
57+
* `OrderablePlugin` surface — `name`, `dependencies`, `optionalDependencies` —
58+
* and the property under test is `AuthPlugin`'s declaration, so the stub is
59+
* the whole of what the resolver would see. The real plugin is composed where
60+
* its bind hook is the subject: `auth-settings-seeded-boot.pin.test.ts` boots
61+
* it (a devDependency, aliased to `src/` in this package's `vitest.config.ts`)
62+
* and pins the read that this edge does NOT order — a Phase-2 `app:seeded`.
6363
*/
6464

6565
import { describe, it, expect } from 'vitest';

0 commit comments

Comments
 (0)