Repository navigation
Commit 36b2889
Part of #15204
Clause-②: no
**T1 of stage 6b-2**: tests only. It deletes the suites that pin the
declared-permission seeder, drift, the `managed_by` normalizer and the
seed-refusal diagnostics, and trims the cases in shared suites that pin
them. It is split off the 6b-2 code PR (#22900) so that PR falls under
3,000 changed lines (the ruling: tests land inside or before their code
PR). No production file changes. The modules these suites pinned are
deleted by #22900.
**Landing, as sequenced by the seat:** T1, T2 and the 6b-2 code PR
(#22900) stay drafts until #22900's own gates clear (the #22865 pickers
and objectui PR-4), then land back to back, **T1 → T2 → #22900**. That
way the publish materializer and the seeders are never live on `main`
with their pins gone. 6b-2a (#22899) is independent and goes to the
maintainer separately.
## Deleted (whole files)
- `bootstrap-declared-permissions.test.ts`
- `walled-platform-bucket-diagnostic.test.ts`
- `permission-set-drift.test.ts`
- `bootstrap-seed-round-trips.test.ts`
- `declared-permission-reload-projection.test.ts`
- `normalize-managed-by.test.ts`
## Trimmed (only the cases that pin a deleted module)
- `per-organization-catalog.test.ts`: case 6 (resolver bleed) is kept.
- `permission-set-name-collision.test.ts`: the shared-derivation
describe is kept.
- `read-fault-distinguishability.test.ts`: reading 1 goes.
- `engine-find-bare-array.pin.test.ts`: blocks 3 and 6 go.
- `seed-name-lookup-degradation-audible.test.ts`: the lit control
reports through `seed-refusal-sink` directly, not through the retiring
diagnostics module.
- `builtin-capabilities.boot.test.ts`: the platform-name-refusal
constant goes.
- `objects/rbac-objects.test.ts`: the `drift_status` pin goes (the field
leaves in 6b-2).
## Re-pinned here
The #11451 fence (a caller that passes no predicate emits only the
`where` key `name`) rode `bootstrap-seed-round-trips.test.ts`, but the
behaviour it pins outlives the seeder: `permission-set-projection.ts`'
overlay pass calls `buildExistingByName` with no predicate. It is now
pinned at the function in
`seed-name-lookup-degradation-audible.test.ts`, on both the batched read
and the per-item degradation read, with a predicate-carrying positive
control. Ablation: making both reads spread `{ managed_by: undefined }`
turned both fences red ("expected [ 'name', 'managed_by' ] to deeply
equal [ 'name' ]"), the control stayed green, and restoring the file
(same sha) brought 8/8 back.
## Gate ledgers
The double-contract ledgers
(`engine-double-contract.{baseline,pinned}.json`,
`objectql-double-limit.baseline.json`) drop the deleted suites' entries.
## Size
16 files, +86 / −2,749 (2,835 changed lines).
## Verification
On this branch: `check:engine-double-contract` and
`check:objectql-double-limit` green. The 7 trimmed suites: 7 files, 60
passed; with the new fence, `seed-name-lookup-degradation-audible` is 8
passed. `check:where-matcher` green. plugin-security typecheck green.
`check:adr-0087-registration`, `check:changeset-no-major`,
`check:cli-command-ids`, `check:nul-bytes` green. **Not covered after
this PR:** no retained test imports `bootstrap-declared-permissions`,
`permission-set-drift`, `normalize-managed-by` or
`seed-refusal-diagnostics`. Only the boot-level suites exercise them in
passing. They run unpinned until #22900 removes them, which is why the
seat lands this PR directly before #22900.
**Merge note:** this PR and #22899 delete adjacent entries in
`scripts/engine-double-contract.baseline.json` and
`scripts/objectql-double-limit.baseline.json`, so whichever lands second
meets a textual conflict there. The resolution is to drop both entries.
Test-only: `skip-changeset`.
---
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_013XKtmoR5QCUSTMjiQ3os49
---------
Co-authored-by: Claude <noreply@anthropic.com>
1 parent 55828c5 commit 36b2889
16 files changed
Lines changed: 86 additions & 2749 deletions
File tree
- packages/plugins/plugin-security/src
- objects
- scripts
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
| |||
255 | 254 | | |
256 | 255 | | |
257 | 256 | | |
258 | | - | |
259 | 257 | | |
260 | 258 | | |
261 | 259 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | | - | |
23 | | - | |
| 22 | + | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
30 | 32 | | |
31 | 33 | | |
32 | 34 | | |
| |||
51 | 53 | | |
52 | 54 | | |
53 | 55 | | |
54 | | - | |
55 | 56 | | |
56 | 57 | | |
57 | | - | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | 246 | | |
270 | 247 | | |
271 | 248 | | |
| |||
321 | 298 | | |
322 | 299 | | |
323 | 300 | | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | 211 | | |
226 | 212 | | |
227 | 213 | | |
| |||
0 commit comments