Repository navigation
fix(service-settings)!: a settings value that misses its type's declared format is refused at the save door and the env door #35490
pr-automation.yml
on: pull_request
Check PR Size
23s
Check Changeset
1m 24s
Auto Label
23s
Annotations
2 errors and 4 notices
|
Check Changeset
Process completed with exit code 1.
|
|
Check Changeset:
.changeset/24882-settings-format-warning.md#L0
.changeset/24882-settings-format-warning.md exists on the merge base and was not added by this PR, so changing or deleting it silently replaces somebody else's release note (#17712). Two things produce this refusal and their remedies are OPPOSITE, so read which one you are before you act. COLLISION -- you and another PR drew the same changeset filename, and yours overwrote theirs. Remedy: rename yours; restore theirs from base. DELIBERATE CORRECTION -- your change may have made this PENDING release note false, and you rewrote it in the same stroke. Remedy: do NOT restore it -- say so on the PR and get it confirmed; restoring it from the base would put the false sentence back.
|
|
Check PR Size
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"
|
|
Auto Label
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"
|
|
Check Changeset:
.changeset/24882-settings-format-refusal.md#L0
ADR-0087 exemption (no-migration-prescription): No metadata moves: no spec key, authorable spelling, object definition or stored shape is added, removed, renamed or re-shaped, and no exported declaration is removed or narrowed, so there is nothing for `objectstack migrate meta` to rewrite. What changes is which runtime values two settings doors accept: a value saved through `PUT /api/settings/:namespace` or `setMany`, and a deployment's `OS_*` environment override. Settings values are runtime state in `sys_setting` (ADR-0007) and environment values belong to the deployment, and no metadata conversion reaches either; a row already stored is not rewritten and is still served. The remedy is to supply a well-formed value, never a rewrite of a metadata source. The other categories are closed on facts: the package publishes (not unpublished); no ADR-0087 id is named or touched (not registered or already-registered); and nothing exported is removed or narrowed (not runtime-interface-only, type-surface-only or runtime-export-retired).
|
|
Check Changeset
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"
|