Skip to content

Commit 52588c5

Browse files
committed
fix(ui): move react from dependencies to peer and dev deps
chore(infra): add pnpm-lock.yaml to .prettierignore
1 parent b645763 commit 52588c5

5 files changed

Lines changed: 28 additions & 7 deletions

File tree

‎.changeset/cozy-teeth-speak.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@node-core/ui-components': patch
3+
---
4+
5+
Move react to peerDependencies and devDependencies to fix runtime duplicate hooks error in consumer applications

‎.prettierignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ node_modules
66
npm-debug.log
77
.npm
88
package-lock.json
9+
pnpm-lock.yaml
910

1011
# Next.js Build Output
1112
.next

‎packages/ui-components/package.json‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@
6161
"@radix-ui/react-tabs": "^1.1.18",
6262
"@radix-ui/react-tooltip": "^1.2.13",
6363
"@vcarl/remark-headings": "~0.1.0",
64-
"classnames": "catalog:",
65-
"react": "catalog:"
64+
"classnames": "catalog:"
6665
},
6766
"devDependencies": {
6867
"@eslint-react/eslint-plugin": "~5.8.6",
@@ -75,7 +74,7 @@
7574
"@tailwindcss/postcss": "~4.3.3",
7675
"@testing-library/user-event": "~14.6.1",
7776
"@types/node": "catalog:",
78-
"@types/react": "catalog:",
77+
"@types/react": "catalog:peer-react19",
7978
"concurrently": "9.2.1",
8079
"cross-env": "catalog:",
8180
"css-loader": "7.1.4",
@@ -86,6 +85,7 @@
8685
"postcss-calc": "~11.2.1",
8786
"postcss-cli": "^11.0.1",
8887
"postcss-loader": "8.2.1",
88+
"react": "catalog:peer-react19",
8989
"storybook": "~10.6.0",
9090
"style-loader": "4.0.0",
9191
"stylelint": "17.14.1",
@@ -96,6 +96,9 @@
9696
"tsx": "4.23.1",
9797
"typescript": "catalog:"
9898
},
99+
"peerDependencies": {
100+
"react": "catalog:peer-react19"
101+
},
99102
"imports": {
100103
"#ui/*": {
101104
"types": [

‎pnpm-lock.yaml‎

Lines changed: 11 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pnpm-workspace.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,8 @@ catalog:
2121
react: ^19.3.0
2222
tailwindcss: ~4.1.17
2323
typescript: 5.9.3
24+
25+
catalogs:
26+
peer-react19:
27+
react: ^19.0.0
28+
'@types/react': ^19.0.0

0 commit comments

Comments
 (0)