From 235ee9b640c9de5366c86c072b065ea98f7b2a45 Mon Sep 17 00:00:00 2001 From: Nigro Simone Date: Wed, 30 Sep 2026 18:13:38 +0200 Subject: [PATCH] benchmark,tools: fix napi benchmarks on GHA The GHA benchmark never built the addons of benchmark/napi, and its --debug-node build made benchmark/common.js look for them in build/Debug. Build them when the napi category runs, and pick the build type as test/common does. Refs: https://github.com/nodejs/node/pull/66395 Signed-off-by: Nigro Simone --- .github/workflows/benchmark.yml | 2 +- benchmark/common.js | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 0e901de78d9a..9f4ed58447df 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -140,7 +140,7 @@ jobs: --arg withPerfetto ${{ matrix.perfetto || false }} \ --arg ccache '(import {}).sccache' \ --run ' - make build-ci -j4 V=1 + make build-ci -j4 V=1 ${{ contains(format(' {0} ', inputs.category), ' napi ') && '&& make bench-addons-build' || '' }} ' tools/nix/ci-shell.nix env: SCCACHE_LOCAL_RW_MODE: READ_ONLY diff --git a/benchmark/common.js b/benchmark/common.js index fa108b706831..734c664c80f5 100644 --- a/benchmark/common.js +++ b/benchmark/common.js @@ -470,7 +470,11 @@ module.exports = { return process.binding(bindingName); } }, - buildType: process.features.debug ? 'Debug' : 'Release', + // As in test/common: a --debug-node build is still a Release build, and its + // addons are in build/Release. + buildType: process.config.target_defaults ? + process.config.target_defaults.default_configuration : + 'Release', createBenchmark(fn, configs, options) { return new Benchmark(fn, configs, options); },