vfs: drop comments that restate the code

The previous commit added comments that narrate what the adjacent code
does. Its commit message already carries the reasoning, so remove them.

Signed-off-by: Philipp Dunkel <pip@pipobscure.com>

Author: pipobscure

lib/fs.js

@@ -1916,8 +1916,6 @@ function readdirSync(path, options) {
     validateBoolean(options.recursive, 'options.recursive');
   }
 
-  // After validation, so a mounted path rejects the same bad arguments as
-  // a real one.
   const h = vfsState.handlers;
   if (h !== null) {
     const result = h.readdirSync(path, options);
@@ -2710,8 +2708,6 @@ function utimes(path, atime, mtime, callback) {
  */
 function utimesSync(path, atime, mtime) {
   path = getValidatedPath(path);
-  // Converted before the VFS hook so a mounted path gets the same
-  // validation and the same seconds-since-epoch numbers as a real one.
   atime = toUnixTimestamp(atime);
   mtime = toUnixTimestamp(mtime);
 

lib/internal/fs/promises.js

@@ -1675,8 +1675,6 @@ async function readdir(path, options) {
 
   path = getValidatedPath(path);
 
-  // After validation, so a mounted path rejects the same bad arguments as
-  // a real one.
   const h = vfsState.handlers;
   if (h !== null) {
     const promise = h.readdir(path, options);
@@ -1957,8 +1955,6 @@ async function chown(path, uid, gid) {
 
 async function utimes(path, atime, mtime) {
   path = getValidatedPath(path);
-  // Converted before the VFS hook so a mounted path gets the same
-  // validation and the same seconds-since-epoch numbers as a real one.
   atime = toUnixTimestamp(atime);
   mtime = toUnixTimestamp(mtime);
 

lib/internal/vfs/dir.js

@@ -95,8 +95,6 @@ class VirtualDir {
     }
   }
 
-  // Disposal is idempotent, as on the native Dir: a handle that was already
-  // closed by hand is not an error to dispose again.
   async [SymbolAsyncDispose]() {
     if (!this.#closed) {
       this.closeSync();

lib/internal/vfs/file_handle.js

@@ -243,8 +243,6 @@ class VirtualFileHandle {
   }
 
   /**
-   * Changes the file mode. Providers whose handles carry no metadata leave
-   * this a no-op; those that do override it.
    * @param {number} mode The new permission bits
    */
   chmodSync(mode) {}
@@ -264,8 +262,6 @@ class VirtualFileHandle {
   async chown() {}
 
   /**
-   * Changes the timestamps. Providers whose handles carry no metadata leave
-   * this a no-op; those that do override it.
    * @param {Date|number|string} atime The new access time
    * @param {Date|number|string} mtime The new modification time
    */
@@ -689,14 +685,10 @@ class MemoryFileHandle extends VirtualFileHandle {
   }
 
   /**
-   * Changes the permission bits of the underlying entry, as fchmod(2) does
-   * through a descriptor. The type bits are kept.
    * @param {number} mode The new permission bits
    */
   chmodSync(mode) {
     this.#checkClosed('fchmod');
-    // Validated here as well because a `FileHandle` calls this method
-    // directly with the caller's argument.
     mode = parseFileMode(mode, 'mode');
     if (this.#entry) {
       this.#entry.mode = (this.#entry.mode & ~0o7777) | (mode & 0o7777);
@@ -705,10 +697,6 @@ class MemoryFileHandle extends VirtualFileHandle {
   }
 
   /**
-   * Changes the timestamps of the underlying entry, as futimes(2) does
-   * through a descriptor. Accepts what `fs.utimes` accepts; the values are
-   * validated and converted here because a `FileHandle` calls this method
-   * directly with the caller's arguments.
    * @param {Date|number|string} atime The new access time
    * @param {Date|number|string} mtime The new modification time
    */

lib/internal/vfs/file_system.js

@@ -371,8 +371,6 @@ class VirtualFileSystem {
   mkdirSync(dirPath, options) {
     const providerPath = this.#toProviderPath(dirPath);
     const created = this[kProvider].mkdirSync(providerPath, options);
-    // A recursive mkdir reports the first directory it created, which the
-    // provider names relative to itself.
     return created === undefined ? undefined : this.#toMountedPath(created);
   }
 
@@ -577,10 +575,8 @@ class VirtualFileSystem {
   }
 
   /**
-   * Converts a mkdtemp prefix to a provider-relative one. The prefix is
-   * text that the random suffix is appended to, not a path to resolve: a
-   * trailing separator means "inside this directory", and resolving would
-   * drop it and turn `dir/` + suffix into a sibling of `dir`.
+   * Converts a mkdtemp prefix to a provider-relative one, keeping a
+   * trailing separator.
    * @param {string} prefix The mounted prefix
    * @returns {string}
    */

lib/internal/vfs/setup.js

@@ -622,8 +622,6 @@ function createVfsHandlers() {
       if (pathStr !== null) {
         const r = findVFSForPath(pathStr);
         if (r !== null) {
-          // A provider watcher polls whatever it is given; the real fs
-          // refuses up front when there is nothing to watch.
           if (!r.vfs.existsSync(pathStr)) throw createENOENT('watch', pathStr);
           return r.vfs.watch(pathStr, options, listener);
         }

test/parallel/test-vfs-fs-hook-gaps.js

@@ -107,6 +107,5 @@ test('a closed Dir can be disposed asynchronously', async () => {
   const dir = mount((l) => l.mkdirSync('/d'));
   const handle = fs.opendirSync(dir);
   handle.closeSync();
-  // Disposal is idempotent on a real Dir.
   await handle[Symbol.asyncDispose]();
 });