zlib: restart format detection when resetting Unzip

Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>

Author: marcopiraccini

src/node_zlib.cc

@@ -203,7 +203,10 @@ class ZlibContext final : public MemoryRetainer {
   void SetFlush(int flush);
   void GetAfterWriteOffsets(uint32_t* avail_in, uint32_t* avail_out) const;
   CompressionError GetErrorInfo() const;
-  inline void SetMode(node_zlib_mode mode) { mode_ = mode; }
+  inline void SetMode(node_zlib_mode mode) {
+    mode_ = mode;
+    auto_detect_ = mode == UNZIP;
+  }
   CompressionError ResetStream();
 
   // Zlib-specific:
@@ -228,6 +231,7 @@ class ZlibContext final : public MemoryRetainer {
  private:
   CompressionError ErrorForMessage(const char* message) const;
   CompressionError SetDictionary();
+  CompressionError ResetZStream();
   bool InitZlib();
 
   Mutex mutex_;  // Protects zlib_init_done_.
@@ -237,6 +241,7 @@ class ZlibContext final : public MemoryRetainer {
   int level_ = 0;
   int mem_level_ = 0;
   node_zlib_mode mode_ = NONE;
+  bool auto_detect_ = false;
   int strategy_ = 0;
   int window_bits_ = 0;
   bool reject_garbage_after_end_ = false;
@@ -1214,7 +1219,7 @@ void ZlibContext::DoThreadPoolWork() {
         // Trailing zero bytes are okay, though, since they are frequently
         // used for padding.
 
-        ResetStream();
+        ResetZStream();
         err_ = inflate(&strm_, flush_);
       }
       break;
@@ -1293,6 +1298,14 @@ CompressionError ZlibContext::ResetStream() {
         Z_STREAM_ERROR);
   }
 
+  if (auto_detect_) {
+    mode_ = UNZIP;
+    gzip_id_bytes_read_ = 0;
+  }
+  return ResetZStream();
+}
+
+CompressionError ZlibContext::ResetZStream() {
   bool first_init_call = InitZlib();
   if (first_init_call && err_ != Z_OK) {
     return ErrorForMessage("Failed to init stream before reset");
@@ -1309,6 +1322,7 @@ CompressionError ZlibContext::ResetStream() {
     case INFLATE:
     case INFLATERAW:
     case GUNZIP:
+    case UNZIP:
       err_ = inflateReset(&strm_);
       break;
     default:

test/parallel/test-zlib-reset-unzip.js

@@ -0,0 +1,38 @@
+'use strict';
+
+// Refs: https://github.com/nodejs/node/issues/64619
+
+const common = require('../common');
+const assert = require('assert');
+const zlib = require('zlib');
+
+function resetAfter(prefix, input, expected) {
+  const chunks = [];
+  const unzip = zlib.createUnzip();
+  unzip.on('error', common.mustNotCall());
+  unzip.on('data', (chunk) => chunks.push(chunk));
+  unzip.on('end', common.mustCall(() => {
+    assert.strictEqual(Buffer.concat(chunks).toString(), expected);
+  }));
+  unzip.write(prefix, common.mustCall(() => {
+    unzip.reset();
+    unzip.end(input);
+  }));
+}
+
+// Reset in the middle of the gzip magic number.
+resetAfter(Buffer.from([0x1f]), zlib.gzipSync('hello'), 'hello');
+
+// Reset after deflate was detected.
+resetAfter(
+  zlib.deflateSync('discarded').subarray(0, 2),
+  Buffer.concat([zlib.gzipSync('abc'), zlib.gzipSync('def'), zlib.gzipSync('ghi')]),
+  'abcdefghi',
+);
+
+// Reset after gzip was detected.
+resetAfter(
+  zlib.gzipSync('discarded').subarray(0, 4),
+  zlib.deflateSync('hello'),
+  'hello',
+);