Skip to content

Commit 4e357c4

Browse files
committed
fixup! build: enable Perfetto by default
except on incompatible platforms
1 parent 6e27bc2 commit 4e357c4

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

‎configure.py‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2273,7 +2273,7 @@ def configure_v8(o, configs):
22732273
options.v8_disable_temporal_support = True
22742274
o['variables']['v8_enable_temporal_support'] = 0 if options.v8_disable_temporal_support else 1
22752275
o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0
2276-
o['variables']['v8_use_perfetto'] = 0 if options.without_perfetto else 1
2276+
o['variables']['v8_use_perfetto'] = 0 if options.without_perfetto or not perfetto_supported() else 1
22772277
o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform)
22782278
o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8)
22792279
o['variables']['force_dynamic_crt'] = 1 if options.shared else 0
@@ -2396,12 +2396,20 @@ def configure_lief(o):
23962396

23972397
configure_library('lief', o, pkgname='LIEF')
23982398

2399+
def perfetto_supported():
2400+
return flavor not in ('aix', 'cloudabi', 'openbsd', 'os400', 'solaris')
2401+
23992402
def configure_perfetto(o):
24002403
if options.without_perfetto:
24012404
if options.shared_perfetto:
24022405
error('--without-perfetto is incompatible with --shared-perfetto')
24032406
o['variables']['node_shared_perfetto'] = b(False)
24042407
return
2408+
if options.without_perfetto is None and not perfetto_supported():
2409+
warn(f'Perfetto is disabled for {flavor}: the bundled perfetto integration '
2410+
'is not available on this platform. Pass --without-perfetto to '
2411+
'silence this warning.')
2412+
return
24052413

24062414
configure_library('perfetto', o)
24072415

0 commit comments

Comments
 (0)