Skip to content

Commit 4bc9d11

Browse files
committed
fixup! build: enable Perfetto by default
except on incompatible platforms
1 parent 188fa07 commit 4bc9d11

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

‎configure.py‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2263,7 +2263,7 @@ def configure_v8(o, configs):
22632263
options.v8_disable_temporal_support = True
22642264
o['variables']['v8_enable_temporal_support'] = 0 if options.v8_disable_temporal_support else 1
22652265
o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0
2266-
o['variables']['v8_use_perfetto'] = 0 if options.without_perfetto else 1
2266+
o['variables']['v8_use_perfetto'] = 0 if options.without_perfetto or not perfetto_supported() else 1
22672267
o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform)
22682268
o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8)
22692269
o['variables']['force_dynamic_crt'] = 1 if options.shared else 0
@@ -2386,12 +2386,20 @@ def configure_lief(o):
23862386

23872387
configure_library('lief', o, pkgname='LIEF')
23882388

2389+
def perfetto_supported():
2390+
return flavor not in ('aix', 'cloudabi', 'openbsd', 'os400', 'solaris')
2391+
23892392
def configure_perfetto(o):
23902393
if options.without_perfetto:
23912394
if options.shared_perfetto:
23922395
error('--without-perfetto is incompatible with --shared-perfetto')
23932396
o['variables']['node_shared_perfetto'] = b(False)
23942397
return
2398+
if options.without_perfetto is None and not perfetto_supported():
2399+
warn(f'Perfetto is disabled for {flavor}: the bundled perfetto integration '
2400+
'is not available on this platform. Pass --without-perfetto to '
2401+
'silence this warning.')
2402+
return
23952403

23962404
configure_library('perfetto', o)
23972405

0 commit comments

Comments
 (0)