fixup! sqlite: reject closing a session from a callback

Cover the `using` form of the rejected disposal, whose block error is
demoted to SuppressedError, and note why the callback check has to stay
below the changeset check in Session::Close().

Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>

Author: TrevorBurnham

src/node_sqlite.cc

@@ -4356,6 +4356,8 @@ void Session::Close(const FunctionCallbackInfo<Value>& args) {
       env, session->session_ == nullptr, "session is not open");
   THROW_AND_RETURN_ON_BAD_STATE(
       env, session->is_generating_changeset_, "session is currently in use");
+  // Checked last: changeset generation runs the authorizer, so both conditions
+  // hold in that case and the more specific message above has to win.
   THROW_AND_RETURN_IF_SESSION_IN_CALLBACK(env, session);
 
   session->Delete();

test/parallel/test-sqlite-session.js

@@ -753,6 +753,35 @@ suite('session.close() - from a callback', () => {
     });
   }
 
+  // Rejecting disposal has a cost: a `using` declaration inside a callback
+  // demotes the block's own error to SuppressedError. Accepted for symmetry
+  // with StatementSync's disposal, which throws for a busy statement the same
+  // way. Pinned here so the trade-off is visible rather than surprising.
+  it('demotes a callback error when disposal is rejected', (t) => {
+    const database = new DatabaseSync(':memory:');
+    database.exec('CREATE TABLE data(key INTEGER PRIMARY KEY)');
+    let caught;
+
+    database.function('f', (x) => {
+      try {
+        using session = database.createSession();
+        t.assert.ok(session);
+        throw new Error('callback error');
+      } catch (err) {
+        caught = err;
+      }
+      return x;
+    });
+
+    database.exec('SELECT f(1)');
+    t.assert.ok(caught instanceof SuppressedError);
+    t.assert.strictEqual(caught.suppressed.message, 'callback error');
+    t.assert.strictEqual(
+      caught.error.message,
+      'session cannot be closed while in a callback',
+    );
+  });
+
   it('leaves an already closed session disposable from a callback', (t) => {
     const database = new DatabaseSync(':memory:');
     database.exec('CREATE TABLE data(key INTEGER PRIMARY KEY)');