Skip to content

Commit 17abd2c

Browse files
committed
test: test disabling type generation
1 parent 1f1a4b5 commit 17abd2c

File tree

3 files changed

+43
-7
lines changed

3 files changed

+43
-7
lines changed

src/lib/converters/files.converter.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ async function generateTSXFiles(conversionOptions: FilesConversionOptions) {
6060
outputDirectory,
6161
iconsFolderName,
6262
completeIconSetName,
63-
generateType && interfaceName,
63+
interfaceName,
64+
generateType,
6465
modelFileName
6566
),
6667
'Export complete icon set'
@@ -116,8 +117,9 @@ async function generateTSFiles(conversionOptions: FilesConversionOptions) {
116117
outputDirectory,
117118
iconsFolderName,
118119
completeIconSetName,
119-
generateType && interfaceName,
120-
modelFileName
120+
interfaceName,
121+
modelFileName,
122+
generateType
121123
),
122124
'Export complete icon set'
123125
);

src/lib/helpers/complete-icon-set-helper.spec.ts

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,31 @@ describe('Complete Iconset-helper', () => {
3838
fileNamesWithDefinitions,
3939
completeIconSetName,
4040
'MyIcon',
41-
'my-icons'
41+
'my-icons',
42+
true
43+
);
44+
expect(unformatedString(expectedContent)).toEqual(unformatedString(generatedContent));
45+
});
46+
it('should not add interface when generateType is false', () => {
47+
let completeIconSetName = 'all-icons';
48+
const fileNamesWithDefinitions = [
49+
{ variableName: 'foo', prefix: 'sampleIcon', filenameWithoutEnding: 'foo' },
50+
{ variableName: 'bar', prefix: 'sampleIcon', filenameWithoutEnding: 'bar' },
51+
{ variableName: 'baz', prefix: 'sampleIcon', filenameWithoutEnding: 'baz' }
52+
] as any;
53+
const expectedContent = `
54+
import {foo} from './sampleIcon-foo.icon';
55+
import {bar} from './sampleIcon-bar.icon';
56+
import {baz} from './sampleIcon-baz.icon';
57+
58+
export const allIcons = [foo, bar, baz];`;
59+
60+
const generatedContent = generateCompleteIconSetContent(
61+
fileNamesWithDefinitions,
62+
completeIconSetName,
63+
'MyIcon',
64+
'my-icons',
65+
false
4266
);
4367
expect(unformatedString(expectedContent)).toEqual(unformatedString(generatedContent));
4468
});

src/lib/helpers/complete-icon-set.helper.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,20 @@ export const generateCompleteIconSetContent = (
88
svgDefinitions: SvgDefinition[],
99
completeIconSetName: string,
1010
interfaceName?: string,
11-
modelFileName?: string
11+
modelFileName?: string,
12+
generateType?: boolean
1213
): string => {
13-
const importSection = generateImportSection(svgDefinitions, interfaceName, modelFileName);
14-
const exportSection = generateExportSection(svgDefinitions, completeIconSetName, FILE_TYPE.TS, interfaceName);
14+
const importSection = generateImportSection(
15+
svgDefinitions,
16+
generateType ? interfaceName : undefined,
17+
generateType ? modelFileName : undefined
18+
);
19+
const exportSection = generateExportSection(
20+
svgDefinitions,
21+
completeIconSetName,
22+
FILE_TYPE.TS,
23+
generateType ? interfaceName : undefined
24+
);
1525
return `${importSection}${exportSection}`;
1626
};
1727

0 commit comments

Comments
 (0)