Skip to content

Commit d8aa7d4

Browse files
committed
fix(lint): fix linting and add group to demo components
1 parent 4758650 commit d8aa7d4

4 files changed

Lines changed: 25 additions & 9 deletions

File tree

projects/ng-sortgrid-demo/src/app/examples/async-pipe/async-pipe-memory.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ <h2 class="card-text">{{ sortOrder }}</h2>
1313
</div>
1414
<ngsg-card *ngFor="let item of item$ | async"
1515
ngSortgridItem
16+
ngSortGridGroup="async-items"
1617
[ngSortGridItems]="item$ | async"
1718
[item]="item"
1819
(sorted)="applyOrder($event)"

projects/ng-sortgrid-demo/src/app/examples/getting-started/getting-started-memory.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ <h5 style="margin-bottom: 20px">3. Drag the items around - hold CMD or Control a
33
<div class="example-container">
44
<ngsg-card *ngFor="let item of items"
55
ngSortgridItem
6+
ngSortGridGroup="getting-started"
67
[ngSortGridItems]="items"
78
[item]="item"
89
class="example-box">

projects/ng-sortgrid-demo/src/app/examples/react-on-changes/react-on-changes-memory.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ <h2 class="card-text">{{ sortOrder }}</h2>
77
<div class="example-container">
88
<ngsg-card *ngFor="let item of items"
99
ngSortgridItem
10+
ngSortGridGroup="react-on-changes"
1011
[item]="item"
1112
[ngSortGridItems]="items"
1213
(sorted)="applyOrder($event)"

projects/ng-sortgrid/src/lib/ngsg-item.directive.spec.ts

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,34 @@ import createSpy = jasmine.createSpy;
1010
import {NgsgElementsHelper} from './ngsg-elements.helper';
1111

1212
describe('NgsgItemDirective', () => {
13-
1413
let sut: NgsgItemDirective;
1514

1615
const elementRef = {nativeElement: {}};
1716
const ngsgSortService = createSpyObj<NgsgSortService>('ngsgSortService', ['initSort', 'sort', 'endSort']);
18-
const ngsgSelectionService = createSpyObj<NgsgSelectionService>('ngsgSelectionService',
19-
['selectElementIfNoSelection', 'updateSelectedDragItem']);
17+
const ngsgSelectionService = createSpyObj<NgsgSelectionService>('ngsgSelectionService', [
18+
'selectElementIfNoSelection',
19+
'updateSelectedDragItem'
20+
]);
2021
const ngsgReflectService = createSpyObj<NgsgReflectService>('ngsgReflectService', ['reflectChanges']);
21-
const ngsgStore = createSpyObj<NgsgStoreService>('ngsgStore',
22-
['initState', 'hasSelectedItems', 'resetSelectedItems', 'hasGroup', 'hasItems', 'setItems']);
22+
const ngsgStore = createSpyObj<NgsgStoreService>('ngsgStore', [
23+
'initState',
24+
'hasSelectedItems',
25+
'resetSelectedItems',
26+
'hasGroup',
27+
'hasItems',
28+
'setItems'
29+
]);
2330
const ngsgEventService = new NgsgEventsService();
2431

2532
beforeEach(() => {
26-
sut = new NgsgItemDirective(elementRef, ngsgSortService, ngsgSelectionService,
27-
ngsgReflectService, ngsgStore, ngsgEventService);
33+
sut = new NgsgItemDirective(
34+
elementRef,
35+
ngsgSortService,
36+
ngsgSelectionService,
37+
ngsgReflectService,
38+
ngsgStore,
39+
ngsgEventService
40+
);
2841
});
2942

3043
it('should set the draggable attribute on the elment', () => {
@@ -241,13 +254,13 @@ describe('NgsgItemDirective', () => {
241254
});
242255

243256
it('should log a warning message if you drop and you did not provide any items', () => {
244-
const expectedWarniningMessage = `Ng-sortgrid: No items provided - please use [sortGridItems] to pass in an array of items -
257+
const expectedWarniningMessage =
258+
`Ng-sortgrid: No items provided - please use [sortGridItems] to pass in an array of items -
245259
otherwhise the ordered items can not be emitted in the (sorted) event`;
246260
const consoleWarnSpy = spyOn(console, 'warn');
247261
ngsgStore.hasItems.and.returnValue(false);
248262

249263
sut.drop(event);
250264
expect(consoleWarnSpy).toHaveBeenCalledWith(expectedWarniningMessage);
251265
});
252-
253266
});

0 commit comments

Comments
 (0)