From b43207e86f15f1441c3262e7a61efc2bc7b6129b Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 28 Sep 2026 16:27:47 +0200 Subject: [PATCH 1/2] fix(sharing): Scope share child permission updates to userroom shares Signed-off-by: Joas Schilling --- lib/Share/RoomShareProvider.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/Share/RoomShareProvider.php b/lib/Share/RoomShareProvider.php index 054f25f7776..e49a27c9d8c 100644 --- a/lib/Share/RoomShareProvider.php +++ b/lib/Share/RoomShareProvider.php @@ -298,6 +298,7 @@ public function update(IShare $share): IShare { $update = $this->dbConnection->getQueryBuilder(); $update->update('share') ->where($update->expr()->eq('parent', $update->createNamedParameter($share->getId()))) + ->andWhere($update->expr()->eq('share_type', $update->createNamedParameter(self::SHARE_TYPE_USERROOM))) ->set('uid_owner', $update->createNamedParameter($share->getShareOwner())) ->set('uid_initiator', $update->createNamedParameter($share->getSharedBy())) ->set('item_source', $update->createNamedParameter($share->getNode()->getId())) @@ -312,6 +313,7 @@ public function update(IShare $share): IShare { $update->update('share') ->where($update->expr()->eq('parent', $update->createNamedParameter($share->getId()))) ->andWhere($update->expr()->neq('permissions', $update->createNamedParameter(0))) + ->andWhere($update->expr()->eq('share_type', $update->createNamedParameter(self::SHARE_TYPE_USERROOM))) ->set('permissions', $update->createNamedParameter($share->getPermissions())) ->executeStatement(); From e30eb01ec3166b57c5a29403549cf58bf5d48a7c Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Fri, 30 Oct 2026 09:29:23 +0100 Subject: [PATCH 2/2] ci(psalm): Remove roave Signed-off-by: Joas Schilling --- .github/workflows/psalm.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/psalm.yml b/.github/workflows/psalm.yml index 164e4c503b2..506020f893d 100644 --- a/.github/workflows/psalm.yml +++ b/.github/workflows/psalm.yml @@ -52,9 +52,6 @@ jobs: composer remove nextcloud/ocp --dev --no-scripts composer i - - name: Check for vulnerable PHP dependencies - run: composer require --dev roave/security-advisories:dev-latest - - name: Install nextcloud/ocp run: composer require --dev nextcloud/ocp:dev-${{ steps.versions.outputs.branches-max }} --ignore-platform-reqs --with-dependencies