diff --git a/lib/private/User/Manager.php b/lib/private/User/Manager.php index 2a87723e1470e..267f212445cd9 100644 --- a/lib/private/User/Manager.php +++ b/lib/private/User/Manager.php @@ -249,7 +249,12 @@ public function checkPassword($loginName, $password) { * @return IUser|false the User object on success, false otherwise */ public function checkPasswordNoLogging($loginName, $password) { - $loginName = str_replace("\0", '', $loginName); + // A NUL byte in the login name must not turn it into a second name for an + // account: the checks done before the password check (e.g. 2FA enforcement + // in Session::logClientIn()) see the name as sent, so the name has to stay the same + if (str_contains($loginName, "\0")) { + return false; + } $password = str_replace("\0", '', $password); $cachedBackend = $this->cache->get($loginName); diff --git a/tests/lib/User/ManagerTest.php b/tests/lib/User/ManagerTest.php index 4f4b761d1c914..60bf4db67e5a7 100644 --- a/tests/lib/User/ManagerTest.php +++ b/tests/lib/User/ManagerTest.php @@ -62,7 +62,6 @@ public function testGetBackends(): void { $this->assertEquals([$userDummyBackend, $dummyDatabaseBackend], $manager->getBackends()); } - public function testUserExistsSingleBackendExists(): void { /** * @var \Test\Util\User\Dummy | \PHPUnit\Framework\MockObject\MockObject $backend @@ -210,6 +209,27 @@ public function testCheckPasswordNotSupported(): void { $this->assertFalse($manager->checkPassword('foo', 'bar')); } + public function testCheckPasswordNullByteInLoginName(): void { + $backend = $this->createMock(\Test\Util\User\Dummy::class); + $backend->expects($this->never()) + ->method('checkPassword'); + + $backend->expects($this->any()) + ->method('implementsActions') + ->willReturnCallback(function ($actions) { + if ($actions === BACKEND::CHECK_PASSWORD) { + return true; + } else { + return false; + } + }); + + $manager = new Manager($this->config, $this->cacheFactory, $this->eventDispatcher, $this->logger); + $manager->registerBackend($backend); + + $this->assertFalse($manager->checkPassword("foo\0", 'bar')); + } + public function testGetOneBackendExists(): void { /** * @var \Test\Util\User\Dummy | \PHPUnit\Framework\MockObject\MockObject $backend @@ -376,8 +396,7 @@ public function testCreateUserInvalid($uid, $password, $exception): void { ->with(\OC\User\Backend::CREATE_USER) ->willReturn(true); - - $manager = new \OC\User\Manager($this->config, $this->cacheFactory, $this->eventDispatcher, $this->logger); + $manager = new Manager($this->config, $this->cacheFactory, $this->eventDispatcher, $this->logger); $manager->registerBackend($backend); $this->expectException(\InvalidArgumentException::class, $exception); @@ -411,7 +430,6 @@ public function testCreateUserSingleBackendNotExists(): void { $this->assertEquals('foo', $user->getUID()); } - public function testCreateUserSingleBackendExists(): void { $this->expectException(\Exception::class); @@ -464,7 +482,6 @@ public function testCreateUserNoBackends(): void { $this->assertFalse($manager->createUser('foo', 'bar')); } - public function testCreateUserFromBackendWithBackendError(): void { $this->expectException(\InvalidArgumentException::class); $this->expectExceptionMessage('Could not create account'); @@ -483,7 +500,6 @@ public function testCreateUserFromBackendWithBackendError(): void { $manager->createUserFromBackend('MyUid', 'MyPassword', $backend); } - public function testCreateUserTwoBackendExists(): void { $this->expectException(\Exception::class);