From 702bc1ffd8c11378948273ba89ee2fec7c3980a8 Mon Sep 17 00:00:00 2001 From: dartcafe Date: Sun, 30 Nov 2025 09:07:28 +0100 Subject: [PATCH 1/3] fix duration Signed-off-by: dartcafe --- CHANGELOG.md | 1 + src/components/Base/modules/DateBox.vue | 7 ++----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 22f4d8c807..55400d9504 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ All notable changes to this project will be documented in this file. ### Fixed - Changed sql query to be ansi safe - Cloning polls + - Fix all day duartion calculation ### Added - Show locale date as tooltip for relative date time information diff --git a/src/components/Base/modules/DateBox.vue b/src/components/Base/modules/DateBox.vue index 479f3068fe..7f03baaa8e 100644 --- a/src/components/Base/modules/DateBox.vue +++ b/src/components/Base/modules/DateBox.vue @@ -25,13 +25,10 @@ const allDay = computed( // subtract a day if allDay is true and luxonDuration is greater than 0 to match the // end of the day after the duration instead of the beginning of the next day const to = computed(() => { - // this is a quick fix which intercepts dayspans crossing daylight saving time changes - // Adding duration as seconds divided by a normal dayspan in seconds (86400) multiplied - // by 86400 ensures that we always land at the same time of day, even if the actual - // dayspan is 23 or 25 hours due to DST changes // FIXME: this should be replaced by a more stable solution + // The last change reintroduced the DST bug (see #4276) if (allDay.value) { - return dateTime.plus((duration.as('seconds') / 86400) * 86400) + return dateTime.plus(duration) } return dateTime .plus(duration) From 703d303539f9f64e5b7c3621deee4328f90a7521 Mon Sep 17 00:00:00 2001 From: dartcafe Date: Sun, 30 Nov 2025 09:09:17 +0100 Subject: [PATCH 2/3] typo Signed-off-by: dartcafe --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 55400d9504..6ff429e15d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ All notable changes to this project will be documented in this file. ### Fixed - Changed sql query to be ansi safe - Cloning polls - - Fix all day duartion calculation + - Fix all day duration calculation ### Added - Show locale date as tooltip for relative date time information From 9fdc05794a1175ec5c2288985e1c93a3faa9e7a2 Mon Sep 17 00:00:00 2001 From: dartcafe Date: Sun, 30 Nov 2025 09:34:45 +0100 Subject: [PATCH 3/3] change log add known bug Signed-off-by: dartcafe --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ff429e15d..61a6b624ad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,10 +6,13 @@ All notable changes to this project will be documented in this file. ## [unreleased] +### Known bugs + - Options of date polls spanning a DST change may result in miscalculated durations + ### Fixed - Changed sql query to be ansi safe - Cloning polls - - Fix all day duration calculation + - Fix all day duration calculation of date polls ### Added - Show locale date as tooltip for relative date time information