From 1126415205c695e9cf9d5db35752641cec186491 Mon Sep 17 00:00:00 2001 From: boomesh11 Date: Mon, 16 Nov 2026 16:52:38 +0530 Subject: [PATCH] fix(tidal): handle null copyright field in Tidal album and track metadata --- streamrip/metadata/album.py | 4 ++-- tests/test_tidal_null_copyright.py | 34 ++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 2 deletions(-) create mode 100644 tests/test_tidal_null_copyright.py diff --git a/streamrip/metadata/album.py b/streamrip/metadata/album.py index 01b48ed2..f5186cee 100644 --- a/streamrip/metadata/album.py +++ b/streamrip/metadata/album.py @@ -301,7 +301,7 @@ def from_tidal(cls, resp) -> AlbumMetadata | None: # genre not returned by API date = typed(resp.get("releaseDate"), str) year = date[:4] - _copyright = typed(resp.get("copyright", ""), str) + _copyright = typed(resp.get("copyright") or "", str) artists = typed(resp.get("artists", []), list) albumartist = ", ".join(a["name"] for a in artists) @@ -384,7 +384,7 @@ def from_tidal_playlist_track_resp(cls, resp: dict) -> AlbumMetadata | None: else: year = "Unknown Year" - _copyright = typed(resp.get("copyright", ""), str) + _copyright = typed(resp.get("copyright") or "", str) artists = typed(resp.get("artists", []), list) albumartist = ", ".join(a["name"] for a in artists) if not albumartist: diff --git a/tests/test_tidal_null_copyright.py b/tests/test_tidal_null_copyright.py new file mode 100644 index 00000000..9ec640b5 --- /dev/null +++ b/tests/test_tidal_null_copyright.py @@ -0,0 +1,34 @@ +from streamrip.metadata.album import AlbumMetadata + + +def test_tidal_from_track_and_album_handles_null_copyright(): + album_resp = { + "allowStreaming": True, + "title": "Test Album", + "id": 123, + "numberOfTracks": 1, + "numberOfVolumes": 1, + "copyright": None, + "releaseDate": "2024-01-01", + "artists": [{"name": "Artist"}], + "explicit": False, + "audioQuality": "LOSSLESS", + "cover": "abc-def", + "mediaMetadata": {"tags": ["LOSSLESS"]}, + } + track_resp = { + "allowStreaming": True, + "title": "Test Track", + "id": 456, + "copyright": None, + "artists": [{"name": "Artist"}], + "explicit": False, + "audioQuality": "LOSSLESS", + "album": {"title": "Test Album", "id": 123, "cover": "abc-def"}, + "mediaMetadata": {"tags": ["LOSSLESS"]}, + } + + from_album = AlbumMetadata.from_tidal(album_resp) + from_track = AlbumMetadata.from_tidal_playlist_track_resp(track_resp) + assert from_album is not None and from_album.copyright == "" + assert from_track is not None and from_track.copyright == ""