Merge pull request #20256 from nicolo-ribaudo/bboxes-when-needed

Only record bboxes when needed

Author: timvandermeij

web/pdf_page_detail_view.js

@@ -187,11 +187,15 @@ class PDFPageDetailView extends BasePDFPageView {
   }
 
   _getRenderingContext(canvas, transform) {
-    const baseContext = this.pageView._getRenderingContext(canvas, transform);
+    const baseContext = this.pageView._getRenderingContext(
+      canvas,
+      transform,
+      false
+    );
     const recordedBBoxes = this.pdfPage.recordedBBoxes;
 
     if (!recordedBBoxes || !this.enableOptimizedPartialRendering) {
-      return { ...baseContext, recordOperations: false };
+      return baseContext;
     }
 
     const {
@@ -211,7 +215,6 @@ class PDFPageDetailView extends BasePDFPageView {
 
     return {
       ...baseContext,
-      recordOperations: false,
       operationsFilter(index) {
         if (recordedBBoxes.isEmpty(index)) {
           return false;

web/pdf_page_view.js

@@ -929,7 +929,7 @@ class PDFPageView extends BasePDFPageView {
     return canvasWrapper;
   }
 
-  _getRenderingContext(canvas, transform) {
+  _getRenderingContext(canvas, transform, recordOperations) {
     return {
       canvas,
       transform,
@@ -939,8 +939,7 @@ class PDFPageView extends BasePDFPageView {
       annotationCanvasMap: this._annotationCanvasMap,
       pageColors: this.pageColors,
       isEditing: this.#isEditing,
-      recordOperations:
-        this.enableOptimizedPartialRendering && !this.recordedBBoxes,
+      recordOperations,
     };
   }
 
@@ -1058,12 +1057,17 @@ class PDFPageView extends BasePDFPageView {
       this.#scaleRoundY = sfy[1];
     }
 
+    const recordBBoxes =
+      this.enableOptimizedPartialRendering &&
+      this.#hasRestrictedScaling &&
+      !this.recordedBBoxes;
+
     // Rendering area
     const transform = outputScale.scaled
       ? [outputScale.sx, 0, 0, outputScale.sy, 0, 0]
       : null;
     const resultPromise = this._drawCanvas(
-      this._getRenderingContext(canvas, transform),
+      this._getRenderingContext(canvas, transform, recordBBoxes),
       () => {
         prevCanvas?.remove();
         this._resetCanvas();