Merge pull request #20328 from calixteman/fix_dialog_position

calixteman · web-flow · commit e1de28c8664b · 2025-10-03T09:17:09.000+02:00
[Editor] Make sure the comment dialog always have relative coordinates between 0% and 100%
diff --git a/web/comment_manager.js b/web/comment_manager.js
@@ -854,8 +854,9 @@ class CommentDialog {
         posY = 0;
       }
     }
-    posX /= innerWidth;
-    posY /= innerHeight;
+
+    posX = MathClamp(posX / innerWidth, 0, 1);
+    posY = MathClamp(posY / innerHeight, 0, 1);
     this.#setPosition(posX, posY);
 
     await this.#overlayManager.open(this.#dialog);

Original file line number	Diff line number	Diff line change
`@@ -854,8 +854,9 @@ class CommentDialog {`
`854`	`854`	`posY = 0;`
`855`	`855`	`}`
`856`	`856`	`}`
`857`		`- posX /= innerWidth;`
`858`		`- posY /= innerHeight;`
	`857`	`+`
	`858`	`+ posX = MathClamp(posX / innerWidth, 0, 1);`
	`859`	`+ posY = MathClamp(posY / innerHeight, 0, 1);`
`859`	`860`	`this.#setPosition(posX, posY);`
`860`	`861`
`861`	`862`	`await this.#overlayManager.open(this.#dialog);`