Commit d01913e
committed
Isolate the "create editor with keyboard" freetext editor integration tests
This commit reduces the number of freetext editor integration test suite
failures, in full isolation, from 6 to 5 by fixing the following issues
in the "create editor with keyboard" block:
- The second test relied on the first test to enable freetext editing
mode and put focus on the page (annotation layer). For isolation we
now do that explicitly in the second test.
- The second test relied on the first test for the editor numbering. For
isolation we change the editor numbering to the one after initial
document load.
Moreover, the test names have been updated to clarify with scenario is
being tested, which came up during comparison of the changes against
commit ea5eafa to make sure that we are still testing the originally
intended scenarios (confirmed by disabling the relevant code from the
commit per scenario and noticing the corresponding test failing).1 parent 94b2c86 commit d01913e
1 file changed
Lines changed: 9 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2340 | 2340 | | |
2341 | 2341 | | |
2342 | 2342 | | |
2343 | | - | |
| 2343 | + | |
2344 | 2344 | | |
2345 | 2345 | | |
2346 | 2346 | | |
2347 | | - | |
| 2347 | + | |
2348 | 2348 | | |
2349 | 2349 | | |
2350 | 2350 | | |
2351 | | - | |
| 2351 | + | |
2352 | 2352 | | |
2353 | 2353 | | |
2354 | 2354 | | |
2355 | 2355 | | |
2356 | | - | |
2357 | 2356 | | |
2358 | 2357 | | |
2359 | 2358 | | |
| |||
2394 | 2393 | | |
2395 | 2394 | | |
2396 | 2395 | | |
2397 | | - | |
| 2396 | + | |
2398 | 2397 | | |
2399 | 2398 | | |
| 2399 | + | |
| 2400 | + | |
| 2401 | + | |
2400 | 2402 | | |
2401 | | - | |
| 2403 | + | |
2402 | 2404 | | |
2403 | 2405 | | |
2404 | 2406 | | |
| |||
2417 | 2419 | | |
2418 | 2420 | | |
2419 | 2421 | | |
2420 | | - | |
| 2422 | + | |
2421 | 2423 | | |
2422 | 2424 | | |
2423 | 2425 | | |
| |||
0 commit comments