Skip to content

Commit 8a5f6f5

Browse files
committed
Use the status property of Jasmine's result object in the custom reporters
This improves readability of the code and makes it consistent with the recently added check for excluded tests.
1 parent 9c21d70 commit 8a5f6f5

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

test/integration/jasmine-boot.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ async function runTests(results) {
5757
return;
5858
}
5959
++results.runs;
60-
if (result.failedExpectations.length === 0) {
60+
if (result.status === "passed") {
6161
console.log(`TEST-PASSED | ${result.description}`);
6262
} else {
6363
++results.failures;
@@ -70,7 +70,7 @@ async function runTests(results) {
7070
return;
7171
}
7272
// Report on the result of `afterAll` invocations.
73-
if (result.failedExpectations.length > 0) {
73+
if (result.status === "failed") {
7474
++results.failures;
7575
console.log(`TEST-UNEXPECTED-FAIL | ${result.description}`);
7676
}

test/reporter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ const TestReporter = function (browser) {
6666
return;
6767
}
6868
// Report on the result of individual tests.
69-
if (result.failedExpectations.length === 0) {
69+
if (result.status === "passed") {
7070
sendResult("TEST-PASSED", result.description);
7171
} else {
7272
let failedMessages = "";
@@ -82,7 +82,7 @@ const TestReporter = function (browser) {
8282
return;
8383
}
8484
// Report on the result of `afterAll` invocations.
85-
if (result.failedExpectations.length > 0) {
85+
if (result.status === "failed") {
8686
let failedMessages = "";
8787
for (const item of result.failedExpectations) {
8888
failedMessages += `${item.message} `;

0 commit comments

Comments
 (0)