Merge pull request #20802 from calixteman/rm_sidebar_resize_observer

Remove the sidebar resize observer when killing the UI

Author: timvandermeij

web/app.js

@@ -529,7 +529,8 @@ const PDFViewerApplication = {
             linkService,
             overlayManager,
             /* ltr = */ l10n.getDirection() === "ltr",
-            hasForcedColors
+            hasForcedColors,
+            abortSignal
           )
         : null;
 
@@ -761,6 +762,7 @@ const PDFViewerApplication = {
         eventBus,
         l10n,
         enableSplitMerge,
+        globalAbortSignal: abortSignal,
       });
       this.viewsManager.onToggled = this.forceRendering.bind(this);
       this.viewsManager.onUpdateThumbnails = () => {

web/comment_manager.js

@@ -45,7 +45,8 @@ class CommentManager {
     linkService,
     overlayManager,
     ltr,
-    hasForcedColors
+    hasForcedColors,
+    globalAbortSignal
   ) {
     const dateFormat = new Intl.DateTimeFormat(undefined, {
       dateStyle: "long",
@@ -69,7 +70,8 @@ class CommentManager {
       linkService,
       this.#popup,
       dateFormat,
-      ltr
+      ltr,
+      globalAbortSignal
     );
     this.#popup.sidebar = this.#sidebar;
     CommentManager.#hasForcedColors = hasForcedColors;
@@ -188,12 +190,14 @@ class CommentSidebar extends Sidebar {
     linkService,
     popup,
     dateFormat,
-    ltr
+    ltr,
+    globalAbortSignal
   ) {
     super(
       { sidebar, resizer: sidebarResizer, toggleButton: commentToolbarButton },
       ltr,
-      /* isResizerOnTheLeft = */ true
+      /* isResizerOnTheLeft = */ true,
+      globalAbortSignal
     );
     this.#sidebarTitle = sidebarTitle;
     this.#commentsList = commentsList;

web/sidebar.js

@@ -54,7 +54,12 @@ class Sidebar {
    * @param {boolean} ltr
    * @param {boolean} isResizerOnTheLeft
    */
-  constructor({ sidebar, resizer, toggleButton }, ltr, isResizerOnTheLeft) {
+  constructor(
+    { sidebar, resizer, toggleButton },
+    ltr,
+    isResizerOnTheLeft,
+    globalAbortSignal
+  ) {
     this._sidebar = sidebar;
     this.#coefficient = ltr === isResizerOnTheLeft ? -1 : 1;
     this.#resizer = resizer;
@@ -74,7 +79,7 @@ class Sidebar {
     toggleButton.addEventListener("click", this.toggle.bind(this));
     this._isOpen = false;
     sidebar.hidden = true;
-
+    globalAbortSignal?.addEventListener("abort", this.destroy.bind(this));
     this.#resizeObserver = new ResizeObserver(
       ([
         {

web/views_manager.js

@@ -99,6 +99,7 @@ class ViewsManager extends Sidebar {
     eventBus,
     l10n,
     enableSplitMerge = false,
+    globalAbortSignal,
   }) {
     super(
       {
@@ -107,7 +108,8 @@ class ViewsManager extends Sidebar {
         toggleButton,
       },
       l10n.getDirection() === "ltr",
-      /* isResizerOnTheLeft = */ false
+      /* isResizerOnTheLeft = */ false,
+      globalAbortSignal
     );
     this.isOpen = false;
     this.active = SidebarView.THUMBS;