Merge pull request #20757 from Snuffleupagus/getPdfFilenameFromUrl-fix-decode-regex

Snuffleupagus · web-flow · commit 86573cc99569 · 2026-02-27T23:14:18.000+01:00
Fix the broken regular expression in the `decode` helper in the `getPdfFilenameFromUrl` function (issue 20664)
diff --git a/src/display/display_utils.js b/src/display/display_utils.js
@@ -377,10 +377,9 @@ function getPdfFilenameFromUrl(url, defaultFilename = "document.pdf") {
       let decoded = decodeURIComponent(name);
       if (decoded.includes("/")) {
         decoded = stripPath(decoded);
-        if (decoded.test(/^\.pdf$/i)) {
-          return decoded;
+        if (/^\.pdf$/i.test(decoded)) {
+          return name;
         }
-        return name;
       }
       return decoded;
     } catch {

Original file line number	Diff line number	Diff line change
`@@ -377,10 +377,9 @@ function getPdfFilenameFromUrl(url, defaultFilename = "document.pdf") {`
`377`	`377`	`let decoded = decodeURIComponent(name);`
`378`	`378`	`if (decoded.includes("/")) {`
`379`	`379`	`decoded = stripPath(decoded);`
`380`		`- if (decoded.test(/^\.pdf$/i)) {`
`381`		`- return decoded;`
	`380`	`+ if (/^\.pdf$/i.test(decoded)) {`
	`381`	`+ return name;`
`382`	`382`	`}`
`383`		`- return name;`
`384`	`383`	`}`
`385`	`384`	`return decoded;`
`386`	`385`	`} catch {`