Merge pull request #20521 from calixteman/issue20520

timvandermeij · web-flow · commit 7f1f5ecf09bc · 2025-12-23T14:49:57.000+01:00
Dont' throw when adding page labels in thumbnails
diff --git a/web/pdf_thumbnail_view.js b/web/pdf_thumbnail_view.js
@@ -449,7 +449,6 @@ class PDFThumbnailView {
    */
   setPageLabel(label) {
     this.pageLabel = typeof label === "string" ? label : null;
-    this.anchor.setAttribute("data-l10n-args", this.#pageL10nArgs);
     this.image.setAttribute("data-l10n-args", this.#pageL10nArgs);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -449,7 +449,6 @@ class PDFThumbnailView {`
`449`	`449`	`*/`
`450`	`450`	`setPageLabel(label) {`
`451`	`451`	`this.pageLabel = typeof label === "string" ? label : null;`
`452`		`- this.anchor.setAttribute("data-l10n-args", this.#pageL10nArgs);`
`453`	`452`	`this.image.setAttribute("data-l10n-args", this.#pageL10nArgs);`
`454`	`453`	`}`
`455`	`454`	`}`