Skip to content

Commit 79058c9

Browse files
committed
Improve addSignatureDescription/editSignatureDescription handling (issue 19683)
- Point the `addSignatureDescription` respectively `editSignatureDescription` labels to their actual `input`-elements (this way clicking the label will actually focus the input). - Add the event listener to the `addSignatureDescription`-input, rather than its `span`-element (this is consistent with the `editSignatureDescription` case). - Correctly check if the `addSignatureDescription`-input is empty, since we're accidentally comparing with its `span`-element. - Remove unbalanced, and likely accidentally added, `</span>` tags.
1 parent 00e3a4d commit 79058c9

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

web/signature_manager.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,10 @@ class SignatureManager {
187187
},
188188
{ passive: true }
189189
);
190-
description.addEventListener(
190+
this.#description.addEventListener(
191191
"input",
192192
() => {
193-
this.#clearDescription.disabled = description.value === "";
193+
this.#clearDescription.disabled = this.#description.value === "";
194194
},
195195
{ passive: true }
196196
);

web/viewer.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -716,9 +716,9 @@
716716
<div id="addSignatureControls">
717717
<div id="horizontalContainer">
718718
<div id="addSignatureDescriptionContainer">
719-
<label for="addSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label"></span></label>
719+
<label for="addSignatureDescInput" data-l10n-id="pdfjs-editor-add-signature-description-label"></label>
720720
<span id="addSignatureDescription" class="inputWithClearButton">
721-
<input type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
721+
<input id="addSignatureDescInput" type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
722722
<button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button>
723723
</span>
724724
</div>
@@ -755,9 +755,9 @@
755755
</div>
756756
<div id="editSignatureDescriptionAndView">
757757
<div id="editSignatureDescriptionContainer">
758-
<label for="editSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label"></span></label>
758+
<label for="editSignatureDescInput" data-l10n-id="pdfjs-editor-add-signature-description-label"></label>
759759
<span id="editSignatureDescription" class="inputWithClearButton">
760-
<input type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
760+
<input id="editSignatureDescInput" type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
761761
<button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button>
762762
</span>
763763
</div>

0 commit comments

Comments
 (0)