Skip to content

Commit 603fd25

Browse files
committed
Fix intermittent failure in the viewer alert tests
It takes some time for the viewer alert to be updated after the editor is committed, but the current tests don't await that and proceed too fast to the viewer alert string assertion. This commit fixes the issue by waiting for the expected viewer alert string to appear instead.
1 parent e4585c2 commit 603fd25

5 files changed

Lines changed: 15 additions & 10 deletions

File tree

test/integration/freetext_editor_spec.mjs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,9 @@ describe("FreeText Editor", () => {
111111
await waitForSelectedEditor(page, editorSelector);
112112
await waitForStorageEntries(page, 1);
113113

114-
const alert = await page.$eval("#viewer-alert", el => el.textContent);
115-
expect(alert).toEqual("Text added");
114+
await page.waitForFunction(
115+
`document.getElementById("viewer-alert").textContent === "Text added"`
116+
);
116117

117118
let content = await page.$eval(editorSelector, el =>
118119
el.innerText.trimEnd()

test/integration/highlight_editor_spec.mjs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,9 @@ describe("Highlight Editor", () => {
7878

7979
await page.waitForSelector(`${getEditorSelector(0)}`);
8080

81-
const alert = await page.$eval("#viewer-alert", el => el.textContent);
82-
expect(alert).toEqual("Highlight added");
81+
await page.waitForFunction(
82+
`document.getElementById("viewer-alert").textContent === "Highlight added"`
83+
);
8384

8485
const oneToOne = Array.from(new Array(13).keys(), n => n + 2).concat(
8586
Array.from(new Array(13).keys(), n => 13 - n)

test/integration/ink_editor_spec.mjs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,9 @@ describe("Ink Editor", () => {
8484
await commit(page);
8585
}
8686

87-
const alert = await page.$eval("#viewer-alert", el => el.textContent);
88-
expect(alert).toEqual("Drawing added");
87+
await page.waitForFunction(
88+
`document.getElementById("viewer-alert").textContent === "Drawing added"`
89+
);
8990

9091
await clearAll(page);
9192

test/integration/signature_editor_spec.mjs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,9 @@ describe("Signature Editor", () => {
181181
{ visible: true }
182182
);
183183

184-
const alert = await page.$eval("#viewer-alert", el => el.textContent);
185-
expect(alert).toEqual("Signature added");
184+
await page.waitForFunction(
185+
`document.getElementById("viewer-alert").textContent === "Signature added"`
186+
);
186187

187188
// Check the tooltip.
188189
await page.waitForSelector(

test/integration/stamp_editor_spec.mjs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,9 @@ describe("Stamp Editor", () => {
125125
const editorSelector = getEditorSelector(0);
126126
await waitForImage(page, editorSelector);
127127

128-
const alert = await page.$eval("#viewer-alert", el => el.textContent);
129-
expect(alert).toEqual("Image added");
128+
await page.waitForFunction(
129+
`document.getElementById("viewer-alert").textContent === "Image added"`
130+
);
130131

131132
const { width } = await getEditorDimensions(page, editorSelector);
132133

0 commit comments

Comments
 (0)