Skip to content

Commit 5a7c872

Browse files
committed
[Editor] Hide the comment sidebar on document change
If the document changes the comment state from the old document should be replaced with that of the new document. To do this the comment manager is destroyed, but the corresponding comment sidebar wasn't destroyed yet, which resulted in the comment state from the old document still being visible for the new document. This commit fixes the issue by hiding the comment sidebar if the comment manager is destroyed. Note that hiding the comment sidebar effectively destroys all its state, and we already set the annotation mode to "none" on document change so we don't want to keep showing the comment sidebar anyway.
1 parent c96fa68 commit 5a7c872

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

web/comment_manager.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,6 +408,7 @@ class CommentManager {
408408
destroy() {
409409
this.#uiManager = null;
410410
this.#finish();
411+
this.#sidebar.hide();
411412
}
412413
}
413414

0 commit comments

Comments
 (0)