Skip to content

Commit 385c936

Browse files
committed
[api-minor] Update the minimum supported Google Chrome version to 118
This patch updates the minimum supported browsers as follows: - Google Chrome 118, which was released on 2023-10-10; see https://chromereleases.googleblog.com/2023/10/stable-channel-update-for-desktop_10.html We haven't made any changes to the supported Google Chrome version for a year, and this change allows us to remove "hacks" needed to support `float: inline-start/inline-end` in old browsers; see https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/float#browser_compatibility. Note that nowadays we usually try, where feasible and possible, to support browsers that are about two years old. By limiting support to only "recent" browsers we reduce the risk of holding back improvements of the *built-in* Firefox PDF Viewer, and also (significantly) reduce the maintenance/support burden for the PDF.js contributors. *Please note:* As always, the minimum supported browser version assumes that a `legacy`-build of the PDF.js library is being used; see https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support
1 parent d0a6531 commit 385c936

4 files changed

Lines changed: 3 additions & 20 deletions

File tree

.stylelintrc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@
1313
"color-no-invalid-hex": true,
1414
"declaration-block-no-duplicate-properties": true,
1515
"declaration-block-no-redundant-longhand-properties": true,
16-
"declaration-property-value-disallowed-list": {
17-
"float": ["inline-start", "inline-end"]
18-
},
1916
"length-zero-no-unit": [true, {
2017
"ignore": ["custom-properties"]
2118
}],

gulpfile.mjs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ const config = JSON.parse(fs.readFileSync(CONFIG_FILE).toString());
8282

8383
const ENV_TARGETS = [
8484
"last 2 versions",
85-
"Chrome >= 110",
85+
"Chrome >= 118",
8686
"Firefox ESR",
8787
"Safari >= 16.4",
8888
"Node >= 20",
@@ -1297,10 +1297,6 @@ function createDefaultPrefsFile() {
12971297
return createStringSource(defaultFileName, buf.join("\n"));
12981298
}
12991299

1300-
function replaceMozcentralCSS() {
1301-
return replace(/var\(--(inline-(?:start|end))\)/g, "$1");
1302-
}
1303-
13041300
gulp.task(
13051301
"mozcentral",
13061302
gulp.series(
@@ -1376,7 +1372,6 @@ gulp.task(
13761372
autoprefixer(MOZCENTRAL_AUTOPREFIXER_CONFIG),
13771373
])
13781374
)
1379-
.pipe(replaceMozcentralCSS())
13801375
.pipe(gulp.dest(MOZCENTRAL_CONTENT_DIR + "web")),
13811376

13821377
preprocessCSS("web/viewer-geckoview.css", gvDefines)
@@ -1386,7 +1381,6 @@ gulp.task(
13861381
autoprefixer(MOZCENTRAL_AUTOPREFIXER_CONFIG),
13871382
])
13881383
)
1389-
.pipe(replaceMozcentralCSS())
13901384
.pipe(gulp.dest(MOZCENTRAL_CONTENT_DIR + "web")),
13911385

13921386
gulp

web/tree.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
}
4747

4848
position: relative;
49-
float: var(--inline-start);
49+
float: inline-start;
5050
height: 0;
5151
width: 0;
5252
color: rgb(255 255 255 / 0.5);

web/viewer.css

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717

1818
:root {
1919
--dir-factor: 1;
20-
/*#if !MOZCENTRAL*/
21-
--inline-start: left;
22-
--inline-end: right;
23-
/*#endif*/
2420

2521
--sidebar-width: 200px;
2622
--sidebar-transition-duration: 200ms;
@@ -132,10 +128,6 @@
132128

133129
:root:dir(rtl) {
134130
--dir-factor: -1;
135-
/*#if !MOZCENTRAL*/
136-
--inline-start: right;
137-
--inline-end: left;
138-
/*#endif*/
139131
}
140132

141133
@media screen and (forced-colors: active) {
@@ -417,7 +409,7 @@ body {
417409
}
418410

419411
.splitToolbarButtonSeparator {
420-
float: var(--inline-start);
412+
float: inline-start;
421413
width: 0;
422414
height: 62%;
423415
border-left: 1px solid var(--separator-color);

0 commit comments

Comments
 (0)