Skip to content

Commit 2bcf2bb

Browse files
Merge pull request #20955 from calixteman/bug2025247
Remove the selection after the pages have been extracted (bug 2025247)
2 parents 7035459 + 12a4fc6 commit 2bcf2bb

2 files changed

Lines changed: 13 additions & 0 deletions

File tree

test/integration/reorganize_pages_spec.mjs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1890,6 +1890,9 @@ describe("Reorganize Pages View", () => {
18901890
await Promise.all(
18911891
pages.map(async ([browserName, page]) => {
18921892
await waitForThumbnailVisible(page, 1);
1893+
const labelSelector = "#viewsManagerStatusActionLabel";
1894+
await waitForTextToBe(page, labelSelector, "Select pages");
1895+
18931896
await waitAndClick(
18941897
page,
18951898
`.thumbnail:has(${getThumbnailSelector(1)}) input`
@@ -1899,6 +1902,8 @@ describe("Reorganize Pages View", () => {
18991902
`.thumbnail:has(${getThumbnailSelector(3)}) input`
19001903
);
19011904

1905+
await waitForTextToBe(page, labelSelector, `${FSI}2${PDI} selected`);
1906+
19021907
const handleExport = await createPromise(page, resolve => {
19031908
window.PDFViewerApplication.eventBus.on(
19041909
"saveextractedpages",
@@ -1919,6 +1924,13 @@ describe("Reorganize Pages View", () => {
19191924
.toEqual([
19201925
{ document: null, pageIndices: [0, 1], includePages: [0, 2] },
19211926
]);
1927+
1928+
await waitForTextToBe(page, labelSelector, "Select pages");
1929+
// All checkboxes should be unchecked.
1930+
await page.waitForSelector(
1931+
"#thumbnailsView:not(:has(input:checked))",
1932+
{ visible: true }
1933+
);
19221934
})
19231935
);
19241936
});

web/pdf_thumbnail_viewer.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -844,6 +844,7 @@ class PDFThumbnailViewer {
844844
});
845845
this.#clearSelection();
846846
this.#toggleMenuEntries(false);
847+
this.#updateStatus("select");
847848
}
848849

849850
#copyPages(clearSelection = true) {

0 commit comments

Comments
 (0)