Skip to content

Commit 20f31d7

Browse files
Merge pull request #20281 from calixteman/comment_dialog_focus
[Editor] Fix the focus outline for the comment dialog buttons
2 parents 05af4ff + a1906f0 commit 20f31d7

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

web/comment_manager.css

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@
3737
align-items: flex-start;
3838
gap: 4px;
3939

40-
*:focus-visible {
41-
outline: 2px solid var(--comment-focus-outline-color);
42-
outline-offset: 0;
43-
}
44-
4540
#commentManagerToolbar {
4641
width: 100%;
4742
height: 32px;

web/viewer.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -792,12 +792,12 @@
792792
</div>
793793
</dialog>
794794

795-
<dialog class="dialog commentManager" id="commentManagerDialog">
795+
<dialog class="dialog commentManager" id="commentManagerDialog" aria-labelledby="commentManagerTitle">
796796
<div class="mainContainer">
797797
<div class="title" id="commentManagerToolbar">
798-
<span id="commentManagerTitle" role="sectionhead" data-l10n-id="pdfjs-editor-edit-comment-dialog-title-when-adding" tabindex="0"></span>
798+
<span id="commentManagerTitle" role="sectionhead" data-l10n-id="pdfjs-editor-edit-comment-dialog-title-when-adding"></span>
799799
</div>
800-
<textarea id="commentManagerTextInput" data-l10n-id="pdfjs-editor-edit-comment-dialog-text-input"></textarea>
800+
<textarea id="commentManagerTextInput" data-l10n-id="pdfjs-editor-edit-comment-dialog-text-input" tabindex="0"></textarea>
801801
<div class="dialogButtonsGroup">
802802
<button id="commentManagerCancelButton" type="button" class="secondaryButton" tabindex="0">
803803
<span data-l10n-id="pdfjs-editor-edit-comment-dialog-cancel-button"></span>

0 commit comments

Comments
 (0)