Skip to content

Commit 167dc5a

Browse files
committed
Add an aria-label to the sidebar resizer (bug 2016142)
1 parent 62ac1b8 commit 167dc5a

3 files changed

Lines changed: 25 additions & 1 deletion

File tree

l10n/en-US/viewer.ftl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -693,6 +693,8 @@ pdfjs-toggle-views-manager-button-label = Toggle Sidebar
693693
694694
pdfjs-views-manager-sidebar =
695695
.aria-label = Sidebar
696+
pdfjs-views-manager-sidebar-resizer =
697+
.aria-label = Sidebar resizer
696698
pdfjs-views-manager-view-selector-button =
697699
.title = Views
698700
pdfjs-views-manager-view-selector-button-label = Views

test/integration/thumbnail_view_spec.mjs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,21 @@ describe("PDF Thumbnail View", () => {
4141
})
4242
);
4343
});
44+
45+
it("should have accessible label on resizer", async () => {
46+
await Promise.all(
47+
pages.map(async ([browserName, page]) => {
48+
await page.click("#viewsManagerToggleButton");
49+
50+
const ariaLabel = await page.$eval("#viewsManagerResizer", el =>
51+
el.getAttribute("aria-label")
52+
);
53+
expect(ariaLabel)
54+
.withContext(`In ${browserName}`)
55+
.toBe("Sidebar resizer");
56+
})
57+
);
58+
});
4459
});
4560

4661
describe("The view is scrolled correctly", () => {

web/viewer.html

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,14 @@
278278
<div id="attachmentsView" class="hidden"></div>
279279
<div id="layersView" class="treeView hidden"></div>
280280
</div>
281-
<div id="viewsManagerResizer" class="sidebarResizer" role="separator" aria-controls="viewsManager" tabindex="0"></div>
281+
<div
282+
id="viewsManagerResizer"
283+
class="sidebarResizer"
284+
role="separator"
285+
aria-controls="viewsManager"
286+
tabindex="0"
287+
data-l10n-id="pdfjs-views-manager-sidebar-resizer"
288+
></div>
282289
</div>
283290
<!-- sidebarContainer -->
284291

0 commit comments

Comments
 (0)