Merge pull request #20351 from calixteman/avoid_null

timvandermeij · web-flow · commit 0fedfc9ceba7 · 2025-10-09T20:57:20.000+02:00
[Editor] Avoid to have a null button in the DOM when there's no comment manager
diff --git a/src/display/editor/editor.js b/src/display/editor/editor.js
@@ -1177,6 +1177,9 @@ class AnnotationEditor {
   }
 
   addStandaloneCommentButton() {
+    if (!this._uiManager.hasCommentManager()) {
+      return;
+    }
     if (this.#commentStandaloneButton) {
       if (this._uiManager.isEditingMode()) {
         this.#commentStandaloneButton.classList.remove("hidden");

Original file line number	Diff line number	Diff line change
`@@ -1177,6 +1177,9 @@ class AnnotationEditor {`
`1177`	`1177`	`}`
`1178`	`1178`
`1179`	`1179`	`addStandaloneCommentButton() {`
	`1180`	`+ if (!this._uiManager.hasCommentManager()) {`
	`1181`	`+ return;`
	`1182`	`+ }`
`1180`	`1183`	`if (this.#commentStandaloneButton) {`
`1181`	`1184`	`if (this._uiManager.isEditingMode()) {`
`1182`	`1185`	`this.#commentStandaloneButton.classList.remove("hidden");`