Skip to content

Commit 0e28b5c

Browse files
authored
Merge pull request #20258 from calixteman/cleanup_before_editing_mode
[Editor] Cleanup the pages not being fully rendered before switching to editing mode
2 parents e8cc25c + 0fc8986 commit 0e28b5c

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

web/pdf_page_view.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1080,6 +1080,10 @@ class PDFPageView extends BasePDFPageView {
10801080
);
10811081
}
10821082
).then(async () => {
1083+
if (this.renderingState !== RenderingStates.FINISHED) {
1084+
// The rendering has been cancelled.
1085+
return;
1086+
}
10831087
this.structTreeLayer ||= new StructTreeLayerBuilder(
10841088
pdfPage,
10851089
viewport.rawDims

web/pdf_viewer.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2525,6 +2525,8 @@ class PDFViewer {
25252525
if (!isEditing) {
25262526
this.pdfDocument.annotationStorage.resetModifiedIds();
25272527
}
2528+
// We need to cleanup whatever pages being rendered.
2529+
this.cleanup();
25282530
for (const pageView of this._pages) {
25292531
pageView.toggleEditingMode(isEditing);
25302532
}

0 commit comments

Comments
 (0)