Skip to content

Protecting the login and password-reset forms is blocked by missing phpBB core events #2

Description

@bonelifer

Hi! I had Claude dig into the login/lost-password limitation mentioned in the README's "Why not using the phpBB CAPTCHA system?" section, to see exactly what's missing, turns out it's not one uniform gap across all three forms.

Login form is actually half-coverable already. core.login_box_before exists and exposes a settable err string before credentials get checked, so the server-side "reject this submission" hook is there. What's actually missing is a template event in login_body.html to render the mosparo widget into the form, that file has zero template events at all.

Both password-reset steps ("forgot password" request, and "enter your new password" after clicking the emailed link) share one template file (ucp_reset_password.html, toggled by a conditional), and neither has a working verification event. The one event each step's PHP controller does have (core.ucp_remind_modify_select_sql, core.ucp_reset_password_modify_select_sql) only lets an extension tweak the SQL lookup query, no way to reject a bad submission.

I opened #1 with RFC docs proposing the specific events needed for all three forms, verified against real phpBB release-3.3.17 core (exact insertion points, current markup, proposed insertion). If these are ever filed as real requests, that happens at tracker.phpbb.com, which needs a phpbb.com account to log in, not an area51.phpbb.com one, those are separate account systems.

Not asking you to pursue this, just leaving the groundwork here in case it's ever useful, happy to hear if I've misjudged the login-form half being closer than the other two.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions