From ddc410dd3c33fd98395007942195cce2a52410fb Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 2 Oct 2026 07:57:01 -0700 Subject: [PATCH 1/2] chore: claim WebSocket paused TLS quest Co-Authored-By: GPT-6 From 9631e3247fd80740ceb20d27da012557bafa295b Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 2 Oct 2026 08:21:12 -0700 Subject: [PATCH 2/2] test(tokio): run fixed-address WebSocket TLS dials on real time Co-Authored-By: GPT-6 --- quest/m1/test-flakes-2/README.md | 1 - quest/m1/test-flakes-2/websocket-paused-tls.md | 14 -------------- rs/moq-tokio/src/websocket.rs | 2 -- 3 files changed, 17 deletions(-) delete mode 100644 quest/m1/test-flakes-2/websocket-paused-tls.md diff --git a/quest/m1/test-flakes-2/README.md b/quest/m1/test-flakes-2/README.md index 2d3287bbfb..20e696a710 100644 --- a/quest/m1/test-flakes-2/README.md +++ b/quest/m1/test-flakes-2/README.md @@ -34,7 +34,6 @@ Public API: none. Wire: none. - [Subscription cut by disconnect](/quest/m1/test-flakes-2/subscription-cut.md) - a publisher disconnect never ends a subscription clean - [Media late join](/quest/m1/test-flakes-2/media-late-join.md) - `just test media` late join stays within one GOP, or the regression is fixed - [js/publish audio clock](/quest/m1/test-flakes-2/publish-audio-clock.md) - the audio encoder delay test runs on mock time -- [WebSocket paused TLS dial](/quest/m1/test-flakes-2/websocket-paused-tls.md) - the fixed-address WebSocket tests stop pausing the clock over a real dial - [moq-mux live import clock](/quest/m1/test-flakes-2/mux-live-import-clock.md) - the live import restart tests advance a paused clock instead of sleeping - [Tracing capture audit](/quest/m1/test-flakes-2/trace-capture-audit.md) - no test misses tracing events because a parallel test silenced the call site diff --git a/quest/m1/test-flakes-2/websocket-paused-tls.md b/quest/m1/test-flakes-2/websocket-paused-tls.md deleted file mode 100644 index d92b724882..0000000000 --- a/quest/m1/test-flakes-2/websocket-paused-tls.md +++ /dev/null @@ -1,14 +0,0 @@ -# [XS] WebSocket fixed-address tests off the paused clock - -## Goal - -moq-tokio websocket `fixed_addresses_keep_tls_name_and_request_host` and -`ipv6_literal_fixed_addresses` no longer pause the clock over a real TLS -dial. - -## Plan - -They pass today, but they pause the clock over a real TLS dial on loopback. -Once a timeout lands on that path, the paused clock can fire it before -loopback delivers, the race [#4527](https://github.com/moq-dev/moq/pull/4527) -removed from the auth outage tests. Remove it the same way. diff --git a/rs/moq-tokio/src/websocket.rs b/rs/moq-tokio/src/websocket.rs index e48d13c961..6e2f5a5cf3 100644 --- a/rs/moq-tokio/src/websocket.rs +++ b/rs/moq-tokio/src/websocket.rs @@ -719,7 +719,6 @@ mod tests { #[tokio::test] async fn fixed_addresses_keep_tls_name_and_request_host() { - tokio::time::pause(); check_tls_authority("relay.example", true, None).await; } @@ -730,7 +729,6 @@ mod tests { #[tokio::test] async fn ipv6_literal_fixed_addresses() { - tokio::time::pause(); check_tls_authority("[::1]", true, None).await; }