From a2091755e6ca06b134108917911d59b5a0eee196 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 2 Oct 2026 07:28:41 -0700 Subject: [PATCH 1/2] chore: claim tracing capture audit Co-Authored-By: GPT-6 From 5007de9655e41c22f32d27c03a8071929fe1bb69 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 2 Oct 2026 07:30:07 -0700 Subject: [PATCH 2/2] chore: complete tracing capture audit Co-Authored-By: GPT-6 --- quest/m1/test-flakes-2/README.md | 1 - quest/m1/test-flakes-2/trace-capture-audit.md | 29 ------------------- 2 files changed, 30 deletions(-) delete mode 100644 quest/m1/test-flakes-2/trace-capture-audit.md diff --git a/quest/m1/test-flakes-2/README.md b/quest/m1/test-flakes-2/README.md index 2d3287bbfb..8580f2b58e 100644 --- a/quest/m1/test-flakes-2/README.md +++ b/quest/m1/test-flakes-2/README.md @@ -36,7 +36,6 @@ Public API: none. Wire: none. - [js/publish audio clock](/quest/m1/test-flakes-2/publish-audio-clock.md) - the audio encoder delay test runs on mock time - [WebSocket paused TLS dial](/quest/m1/test-flakes-2/websocket-paused-tls.md) - the fixed-address WebSocket tests stop pausing the clock over a real dial - [moq-mux live import clock](/quest/m1/test-flakes-2/mux-live-import-clock.md) - the live import restart tests advance a paused clock instead of sleeping -- [Tracing capture audit](/quest/m1/test-flakes-2/trace-capture-audit.md) - no test misses tracing events because a parallel test silenced the call site ## Related diff --git a/quest/m1/test-flakes-2/trace-capture-audit.md b/quest/m1/test-flakes-2/trace-capture-audit.md deleted file mode 100644 index 7dca6d7ea8..0000000000 --- a/quest/m1/test-flakes-2/trace-capture-audit.md +++ /dev/null @@ -1,29 +0,0 @@ -# [XS] Tracing captures survive the call-site cache - -## Goal - -No test in the workspace counts or asserts tracing events through a -thread-scoped subscriber (`with_default`, `set_default`) that a parallel -test can silence under a shared-process `cargo test`. - -## Plan - -#4690 found that tracing caches, per call site and for the whole process, -whether any subscriber wants its events. With only scoped subscribers, the -first thread to hit a call site decides for everyone, so a parallel test on a -thread with no subscriber turns the event off and the capture misses it. -Nextest runs each test in its own process and can't hit it, but `cargo test` -does. - -Start after #4690 lands, with its open review finding on the subscriber -installation window resolved, so the race isn't copied into other crates. - -Grep the Rust crates for tests that capture tracing output with scoped -subscribers. Move each one onto #4690's pattern in -`rs/moq-net/src/model/test_tracing.rs` (one process-wide subscriber, events -routed to a per-thread capture). Its helper only counts WARN events by -message, so a capture that asserts something else needs the helper -generalized, or a shared copy if other crates need it. If none turn up, delete -this quest. - -Public API: none. Wire: none.