From f7a5d0e53477eb0f1c06f14f1f842aa52c3e51f9 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 25 Sep 2026 10:07:50 -0700 Subject: [PATCH 1/2] fix(ffi): name the binary config conversion so moq-ffi compiles Two IntoRendition impls now satisfy the binary track constructors, so a bare into() no longer infers its target. Co-Authored-By: Claude Opus 5.5 --- rs/moq-ffi/src/binary.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rs/moq-ffi/src/binary.rs b/rs/moq-ffi/src/binary.rs index 8e343bd2ad..6538654021 100644 --- a/rs/moq-ffi/src/binary.rs +++ b/rs/moq-ffi/src/binary.rs @@ -48,7 +48,7 @@ impl MoqBroadcastProducer { let _guard = crate::ffi::enter(); self.with_state(|state| { let track = state.broadcast.create_track(name, None)?; - let producer = state.catalog.binary_snapshot(track, config.into())?; + let producer = state.catalog.binary_snapshot(track, moq_mux::binary::Config::from(config))?; Ok(Arc::new(MoqBinarySnapshotProducer { inner: std::sync::Mutex::new(Some(producer)), })) @@ -66,7 +66,7 @@ impl MoqBroadcastProducer { let _guard = crate::ffi::enter(); self.with_state(|state| { let track = state.broadcast.create_track(name, None)?; - let producer = state.catalog.binary_stream(track, config.into())?; + let producer = state.catalog.binary_stream(track, moq_mux::binary::Config::from(config))?; Ok(Arc::new(MoqBinaryStreamProducer { inner: std::sync::Mutex::new(Some(producer)), })) From 53611f4010bf8aecc9d39aeaf13c67e8d1860a71 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 25 Sep 2026 12:21:42 -0700 Subject: [PATCH 2/2] style(ffi): rustfmt the named binary config conversion --- rs/moq-ffi/src/binary.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/rs/moq-ffi/src/binary.rs b/rs/moq-ffi/src/binary.rs index 6538654021..3c231757f7 100644 --- a/rs/moq-ffi/src/binary.rs +++ b/rs/moq-ffi/src/binary.rs @@ -48,7 +48,9 @@ impl MoqBroadcastProducer { let _guard = crate::ffi::enter(); self.with_state(|state| { let track = state.broadcast.create_track(name, None)?; - let producer = state.catalog.binary_snapshot(track, moq_mux::binary::Config::from(config))?; + let producer = state + .catalog + .binary_snapshot(track, moq_mux::binary::Config::from(config))?; Ok(Arc::new(MoqBinarySnapshotProducer { inner: std::sync::Mutex::new(Some(producer)), })) @@ -66,7 +68,9 @@ impl MoqBroadcastProducer { let _guard = crate::ffi::enter(); self.with_state(|state| { let track = state.broadcast.create_track(name, None)?; - let producer = state.catalog.binary_stream(track, moq_mux::binary::Config::from(config))?; + let producer = state + .catalog + .binary_stream(track, moq_mux::binary::Config::from(config))?; Ok(Arc::new(MoqBinaryStreamProducer { inner: std::sync::Mutex::new(Some(producer)), }))