From a317a1440d47d71a00c17679363e6fc683d66bbb Mon Sep 17 00:00:00 2001 From: Matt LaPaglia Date: Sun, 15 Nov 2026 20:54:43 -0500 Subject: [PATCH] Address open code scanning alerts - Strip line breaks from the unrecognized webhook payload before logging it, and cap it at 1000 characters, so unauthenticated input can't forge log entries (cs/log-forging). - Default both workflows to a read-only GITHUB_TOKEN and grant write access only to the jobs that need it: contents: write for the Windows release job, and contents: write plus packages: read for the alpha release cleanup (actions/missing-workflow-permissions). --- .github/workflows/cleanup-alpha-releases.yml | 10 +++++++++- .github/workflows/docker-publish.yml | 6 ++++++ .../Features/Webhooks/WebhookController.cs | 12 +++++++++++- 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cleanup-alpha-releases.yml b/.github/workflows/cleanup-alpha-releases.yml index 4b8334b3..d6a669c3 100644 --- a/.github/workflows/cleanup-alpha-releases.yml +++ b/.github/workflows/cleanup-alpha-releases.yml @@ -5,6 +5,9 @@ on: tags: - 'v[0-9]+.[0-9]+.[0-9]+' +permissions: + contents: read + env: IMAGE_NAME: OpenAlprWebhookProcessor @@ -12,7 +15,12 @@ jobs: cleanup-alpha-releases: runs-on: ubuntu-latest if: github.event_name == 'push' && contains(github.ref, 'refs/tags/') && !contains(github.ref, 'alpha') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc') - + permissions: + # Deletes alpha releases and their git tags + contents: write + # Lists container package versions to find alpha Docker tags + packages: read + steps: - name: Checkout code uses: actions/checkout@v4 diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml index cd199eac..467204e2 100644 --- a/.github/workflows/docker-publish.yml +++ b/.github/workflows/docker-publish.yml @@ -8,6 +8,9 @@ on: - develop pull_request: +permissions: + contents: read + env: IMAGE_NAME: OpenAlprWebhookProcessor @@ -84,6 +87,9 @@ jobs: windows-build-push: runs-on: ubuntu-latest if: github.event_name == 'push' && contains(github.ref, 'refs/tags/') + permissions: + # Creates the GitHub release and uploads its artifact + contents: write steps: - name: Check out the repo uses: actions/checkout@main diff --git a/OpenAlprWebhookProcessor.Server/Features/Webhooks/WebhookController.cs b/OpenAlprWebhookProcessor.Server/Features/Webhooks/WebhookController.cs index 8066ff52..61f9d458 100644 --- a/OpenAlprWebhookProcessor.Server/Features/Webhooks/WebhookController.cs +++ b/OpenAlprWebhookProcessor.Server/Features/Webhooks/WebhookController.cs @@ -19,6 +19,8 @@ namespace OpenAlprWebhookProcessor.Features.Webhooks [Route("api/webhook")] public class WebhookController : ControllerBase { + private const int MaxLoggedPayloadLength = 1000; + private readonly ILogger _logger; private readonly IMediator _mediator; @@ -82,7 +84,15 @@ public async Task Post(CancellationToken cancellationToken) } else { - _logger.LogDebug("Unknown payload received, ignoring: {RawWebhook}", rawWebhook); + // The body is unauthenticated input: strip line breaks so it can't forge + // log entries, and cap its length so it can't flood the log. + var preview = rawWebhook.Length > MaxLoggedPayloadLength + ? rawWebhook[..MaxLoggedPayloadLength] + : rawWebhook; + _logger.LogDebug( + "Unknown payload received ({Length} chars), ignoring: {RawWebhook}", + rawWebhook.Length, + preview.Replace("\r", string.Empty).Replace("\n", string.Empty)); } }