fix: Don't add parentheses around comprehension target (implicit) tuple

Issue-mkdocstrings-python-311: mkdocstrings/python#311

Author: pawamoy

src/griffe/_internal/expressions.py

@@ -1164,7 +1164,7 @@ def _build_compare(node: ast.Compare, parent: Module | Class, **kwargs: Any) ->
 
 def _build_comprehension(node: ast.comprehension, parent: Module | Class, **kwargs: Any) -> Expr:
     return ExprComprehension(
-        _build(node.target, parent, **kwargs),
+        _build(node.target, parent, compr_target=True, **kwargs),
         _build(node.iter, parent, **kwargs),
         [_build(condition, parent, **kwargs) for condition in node.ifs],
         is_async=bool(node.is_async),
@@ -1325,7 +1325,7 @@ def _build_subscript(
     *,
     parse_strings: bool = False,
     literal_strings: bool = False,
-    in_subscript: bool = False,  # noqa: ARG001
+    subscript_slice: bool = False,  # noqa: ARG001
     **kwargs: Any,
 ) -> Expr:
     left = _build(node.value, parent, **kwargs)
@@ -1340,22 +1340,23 @@ def _build_subscript(
             parent,
             parse_strings=True,
             literal_strings=literal_strings,
-            in_subscript=True,
+            subscript_slice=True,
             **kwargs,
         )
     else:
-        slice_expr = _build(node.slice, parent, in_subscript=True, **kwargs)
+        slice_expr = _build(node.slice, parent, subscript_slice=True, **kwargs)
     return ExprSubscript(left, slice_expr)
 
 
 def _build_tuple(
     node: ast.Tuple,
     parent: Module | Class,
     *,
-    in_subscript: bool = False,
+    subscript_slice: bool = False,
+    compr_target: bool = False,
     **kwargs: Any,
 ) -> Expr:
-    return ExprTuple([_build(el, parent, **kwargs) for el in node.elts], implicit=in_subscript)
+    return ExprTuple([_build(el, parent, **kwargs) for el in node.elts], implicit=subscript_slice or compr_target)
 
 
 def _build_unaryop(node: ast.UnaryOp, parent: Module | Class, **kwargs: Any) -> Expr:

tests/test_expressions.py

@@ -233,7 +233,6 @@ def func[Z](arg1: T, arg2: Y): pass
         assert module["C.func"].parameters["arg2"].annotation.canonical_path == "Y"
 
 
-@pytest.mark.xfail(reason="Tuple in comprehension target is not yet implicit")
 def test_render_dict_comprehension() -> None:
     """Assert dict comprehensions are rendered correctly."""
     with temporary_visited_module(