Summary
integration_test.go's TestCommandArchitecture test (majorCommands list in the "all major commands exist" subtest) only checks for backup, restore, nabsl-request, nonadmin, client, version. It does not assert the presence of schedule, backup-location, must-gather, and setup, even though cmd/root.go registers all of these commands via schedule.NewCommand(f), backuplocation.NewCommand(f), mustgather.NewMustGatherCommand(f), and setup.NewSetupCommand(f).
This was confirmed on main/oadp-dev, oadp-1.6, and oadp-1.5 — the commands exist in cmd/root.go on all of them, but the integration test's command list was never updated to cover them.
PR #212 fixes this only for the oadp-1.4 branch (see #212, comment #212 (comment)).
Affected branches
main / oadp-dev
oadp-1.6
oadp-1.5
Required change
In integration_test.go, update the majorCommands slice in TestCommandArchitecture's "all major commands exist" subtest to include schedule, backup-location, must-gather, and setup (mirroring the fix applied to oadp-1.4 in PR #212).
Acceptance criteria
Requested by @kaovilai
Summary
integration_test.go'sTestCommandArchitecturetest (majorCommandslist in the "all major commands exist" subtest) only checks forbackup,restore,nabsl-request,nonadmin,client,version. It does not assert the presence ofschedule,backup-location,must-gather, andsetup, even thoughcmd/root.goregisters all of these commands viaschedule.NewCommand(f),backuplocation.NewCommand(f),mustgather.NewMustGatherCommand(f), andsetup.NewSetupCommand(f).This was confirmed on
main/oadp-dev,oadp-1.6, andoadp-1.5— the commands exist incmd/root.goon all of them, but the integration test's command list was never updated to cover them.PR #212 fixes this only for the
oadp-1.4branch (see #212, comment #212 (comment)).Affected branches
main/oadp-devoadp-1.6oadp-1.5Required change
In
integration_test.go, update themajorCommandsslice inTestCommandArchitecture's "all major commands exist" subtest to includeschedule,backup-location,must-gather, andsetup(mirroring the fix applied tooadp-1.4in PR #212).Acceptance criteria
main/oadp-devintegration test assertsschedule,backup-location,must-gather,setupin root--helpoutputoadp-1.6integration test updated similarlyoadp-1.5integration test updated similarlyRequested by @kaovilai