Skip to content

Commit 6bbebe6

Browse files
kennykerrkennykerr
authored
Apply clippy workflow to all but tests (#3675)
1 parent 8c7bfd0 commit 6bbebe6

File tree

4 files changed

+143
-26
lines changed

4 files changed

+143
-26
lines changed

‎.github/workflows/clippy.yml‎

Lines changed: 136 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,126 @@ jobs:
3030
target: x86_64-pc-windows-msvc
3131
- name: Check cppwinrt
3232
run: cargo clippy -p cppwinrt
33+
- name: Check csharp_client
34+
run: cargo clippy -p csharp_client
35+
- name: Check csharp_component
36+
run: cargo clippy -p csharp_component
37+
- name: Check helpers
38+
run: cargo clippy -p helpers
39+
- name: Check sample_bits
40+
run: cargo clippy -p sample_bits
41+
- name: Check sample_com_uri
42+
run: cargo clippy -p sample_com_uri
43+
- name: Check sample_consent
44+
run: cargo clippy -p sample_consent
45+
- name: Check sample_core_app
46+
run: cargo clippy -p sample_core_app
47+
- name: Check sample_counter
48+
run: cargo clippy -p sample_counter
49+
- name: Check sample_counter_sys
50+
run: cargo clippy -p sample_counter_sys
51+
- name: Check sample_create_window
52+
run: cargo clippy -p sample_create_window
53+
- name: Check sample_create_window_sys
54+
run: cargo clippy -p sample_create_window_sys
55+
- name: Check sample_credentials
56+
run: cargo clippy -p sample_credentials
57+
- name: Check sample_data_protection
58+
run: cargo clippy -p sample_data_protection
59+
- name: Check sample_dcomp
60+
run: cargo clippy -p sample_dcomp
61+
- name: Check sample_delay_load
62+
run: cargo clippy -p sample_delay_load
63+
- name: Check sample_delay_load_sys
64+
run: cargo clippy -p sample_delay_load_sys
65+
- name: Check sample_device_watcher
66+
run: cargo clippy -p sample_device_watcher
67+
- name: Check sample_direct2d
68+
run: cargo clippy -p sample_direct2d
69+
- name: Check sample_direct3d12
70+
run: cargo clippy -p sample_direct3d12
71+
- name: Check sample_enum_windows
72+
run: cargo clippy -p sample_enum_windows
73+
- name: Check sample_enum_windows_sys
74+
run: cargo clippy -p sample_enum_windows_sys
75+
- name: Check sample_file_dialogs
76+
run: cargo clippy -p sample_file_dialogs
77+
- name: Check sample_json_validator
78+
run: cargo clippy -p sample_json_validator
79+
- name: Check sample_json_validator_client
80+
run: cargo clippy -p sample_json_validator_client
81+
- name: Check sample_json_validator_winrt
82+
run: cargo clippy -p sample_json_validator_winrt
83+
- name: Check sample_json_validator_winrt_client
84+
run: cargo clippy -p sample_json_validator_winrt_client
85+
- name: Check sample_json_validator_winrt_client_cpp
86+
run: cargo clippy -p sample_json_validator_winrt_client_cpp
87+
- name: Check sample_kernel_event
88+
run: cargo clippy -p sample_kernel_event
89+
- name: Check sample_memory_buffer
90+
run: cargo clippy -p sample_memory_buffer
91+
- name: Check sample_message_box
92+
run: cargo clippy -p sample_message_box
93+
- name: Check sample_message_box_sys
94+
run: cargo clippy -p sample_message_box_sys
95+
- name: Check sample_ocr
96+
run: cargo clippy -p sample_ocr
97+
- name: Check sample_overlapped
98+
run: cargo clippy -p sample_overlapped
99+
- name: Check sample_privileges
100+
run: cargo clippy -p sample_privileges
101+
- name: Check sample_privileges_sys
102+
run: cargo clippy -p sample_privileges_sys
103+
- name: Check sample_rss
104+
run: cargo clippy -p sample_rss
105+
- name: Check sample_service_simple
106+
run: cargo clippy -p sample_service_simple
107+
- name: Check sample_service_sys
108+
run: cargo clippy -p sample_service_sys
109+
- name: Check sample_service_thread
110+
run: cargo clippy -p sample_service_thread
111+
- name: Check sample_service_time
112+
run: cargo clippy -p sample_service_time
113+
- name: Check sample_shell
114+
run: cargo clippy -p sample_shell
115+
- name: Check sample_simple
116+
run: cargo clippy -p sample_simple
117+
- name: Check sample_spellchecker
118+
run: cargo clippy -p sample_spellchecker
119+
- name: Check sample_task_dialog
120+
run: cargo clippy -p sample_task_dialog
121+
- name: Check sample_task_dialog_sys
122+
run: cargo clippy -p sample_task_dialog_sys
123+
- name: Check sample_thread_pool_work
124+
run: cargo clippy -p sample_thread_pool_work
125+
- name: Check sample_thread_pool_work_sys
126+
run: cargo clippy -p sample_thread_pool_work_sys
127+
- name: Check sample_uiautomation
128+
run: cargo clippy -p sample_uiautomation
129+
- name: Check sample_wmi
130+
run: cargo clippy -p sample_wmi
131+
- name: Check sample_xml
132+
run: cargo clippy -p sample_xml
133+
- name: Check tool_bindgen
134+
run: cargo clippy -p tool_bindgen
135+
- name: Check tool_bindings
136+
run: cargo clippy -p tool_bindings
137+
- name: Check tool_gnu
138+
run: cargo clippy -p tool_gnu
139+
- name: Check tool_license
140+
run: cargo clippy -p tool_license
141+
- name: Check tool_merge
142+
run: cargo clippy -p tool_merge
143+
- name: Check tool_msvc
144+
run: cargo clippy -p tool_msvc
145+
- name: Check tool_standalone
146+
run: cargo clippy -p tool_standalone
147+
- name: Check tool_test_all
148+
run: cargo clippy -p tool_test_all
149+
- name: Check tool_workspace
150+
run: cargo clippy -p tool_workspace
151+
- name: Check tool_yml
152+
run: cargo clippy -p tool_yml
33153
- name: Check windows
34154
run: cargo clippy -p windows
35155
- name: Check windows-bindgen
@@ -66,25 +186,19 @@ jobs:
66186
run: cargo clippy -p windows-threading
67187
- name: Check windows-version
68188
run: cargo clippy -p windows-version
69-
- name: Check helpers
70-
run: cargo clippy -p helpers
71-
- name: Check tool_bindgen
72-
run: cargo clippy -p tool_bindgen
73-
- name: Check tool_bindings
74-
run: cargo clippy -p tool_bindings
75-
- name: Check tool_gnu
76-
run: cargo clippy -p tool_gnu
77-
- name: Check tool_license
78-
run: cargo clippy -p tool_license
79-
- name: Check tool_merge
80-
run: cargo clippy -p tool_merge
81-
- name: Check tool_msvc
82-
run: cargo clippy -p tool_msvc
83-
- name: Check tool_standalone
84-
run: cargo clippy -p tool_standalone
85-
- name: Check tool_test_all
86-
run: cargo clippy -p tool_test_all
87-
- name: Check tool_workspace
88-
run: cargo clippy -p tool_workspace
89-
- name: Check tool_yml
90-
run: cargo clippy -p tool_yml
189+
- name: Check windows_aarch64_gnullvm
190+
run: cargo clippy -p windows_aarch64_gnullvm
191+
- name: Check windows_aarch64_msvc
192+
run: cargo clippy -p windows_aarch64_msvc
193+
- name: Check windows_i686_gnu
194+
run: cargo clippy -p windows_i686_gnu
195+
- name: Check windows_i686_gnullvm
196+
run: cargo clippy -p windows_i686_gnullvm
197+
- name: Check windows_i686_msvc
198+
run: cargo clippy -p windows_i686_msvc
199+
- name: Check windows_x86_64_gnu
200+
run: cargo clippy -p windows_x86_64_gnu
201+
- name: Check windows_x86_64_gnullvm
202+
run: cargo clippy -p windows_x86_64_gnullvm
203+
- name: Check windows_x86_64_msvc
204+
run: cargo clippy -p windows_x86_64_msvc

‎crates/samples/windows/data_protection/src/main.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ fn main() -> std::io::Result<()> {
2222
Ok(())
2323
}
2424

25+
#[allow(clippy::mut_from_ref)]
2526
unsafe fn as_mut_bytes(buffer: &IBuffer) -> Result<&mut [u8]> {
2627
let interop = buffer.cast::<IBufferByteAccess>()?;
2728

‎crates/samples/windows/memory_buffer/src/main.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ use windows::{core::*, Foundation::*, Win32::System::WinRT::IMemoryBufferByteAcc
55
// this function does not perform borrow/lifetime checking. The caller must ensure that the
66
// IMemoryBufferReference remains alive and that that buffer is not shared across threads.
77

8+
#[allow(clippy::mut_from_ref)]
89
unsafe fn as_mut_slice(buffer: &IMemoryBufferReference) -> Result<&mut [u8]> {
910
let interop = buffer.cast::<IMemoryBufferByteAccess>()?;
1011
let mut data = std::ptr::null_mut();

‎crates/tools/yml/src/clippy.rs‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,13 @@ jobs:
3535

3636
// This unrolling is required since "cargo clippy --all" consumes too much memory for the GitHub hosted runners.
3737

38-
for package in helpers::crates("crates/libs")
39-
.iter()
40-
.chain(helpers::crates("crates/tools").iter())
41-
{
38+
for package in helpers::crates("crates") {
4239
let name = &package.name;
4340

41+
if name.starts_with("test") {
42+
continue;
43+
}
44+
4445
write!(
4546
&mut yml,
4647
r"

0 commit comments

Comments
 (0)