Add --proxy-bypass-list support in argv.json

[patrickhernon]

Add support for --proxy-bypass-list in the argv.json file so that we can provide a default proxy bypass list to VS Code users.

Setting NO_PROXY doesn't work as a solution because it would either have to be set as a user / system environment variable thus impacting all applications, or we would have to rely on our VS Code users to explicitly pass --proxy-bypass-list as an argument to code on the command line each time they launch. Having the option to set this in argv.json would provide us with a way to package this in our default enterprise installation of VS Code so users would get this setting by default, but just for VS Code.

[isidorn]

Could we just expose proxy-bypass-list in argv.json. I was not aware that only a subset of our command line arguments can be configured there actually.

fyi Robo (@deepak1556)

[deepak1556]

Yes we can expose it

I was not aware that only a subset of our command line arguments can be configured there actually.

Yeah the list of chromium commandline flags in quit large and always changes with version updates it would be a nightmare if we are to support all of them in argv.json. At this time we only support those on a case by case basis.

[isidorn]

Thanks, makes sense! Should I assign this one to you?
If you are busy, I am happy to provide a PR in July if you give me a code pointer?

[deepak1556]

Here is an example of recent argv.json flag addition 8a3f7e9, feel free to send a PR. I can review it. Thanks!

[isidorn]

Thanks for that great example. Here's the PR #216716
I verified that adding "proxy-bypass-list" does not produce errors in argv.json
I did not verify if this list actually gets passed to Chrome. We can ask patrickhernon if we get this out to an insiders build.

[chrmarti]

FYI: There is a PR in progress for adding a setting for the NO_PROXY feature: #211958

[isidorn]

Thanks. But unlike that PR, I think this flag just needs to be passed to Chromium and it should get handled. i.e. I did not add any code in VS Code that actually handles the flag.