Terminal profile settings not reflected in terminals created using VSCode API

[karrtikr]

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.83.0-insider
Commit: 03671d332bf6a34782d5adc64086bc8e083a1590
Date: 2023-09-12T15:02:37.804Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36

Steps to Reproduce:

1. Configure fish profile to also set an environment variable:

        "fish": {
            "path": "fish",
            "env": {
                "fish_history": "history"
            }
        },

2. Select this as default terminal profile

3. Create a terminal and print variables, notice fish_history is present:
   

4. Create a terminal using vscode.window.createTerminal() API, notice many variables including this are not present:
   

For Python extension, this leads to "Python" terminals being different from the selected terminal: microsoft/vscode-python#21960. Created on behalf of Kyochikuto | キョウチクトウ (@kyochikuto).

[Tyriar]

I think this is by design because you're launching a shell, not a profile. Unless you don't specify a shellPath in which case I haven't really thought about what's meant to happen.

I believe we're always launching a shell, but with terminal.integrated.profiles.linux we just customize as to how we're doing it. Right now I can manually hit New Terminal and then do python script.py to have the profile settings set during execution but it's somehow cumbersome.

And if it is by design, I'm curious as to why and what are the benefits (since it seems counter-intuitive to me IMHO)?

[Tyriar]

Kyochikuto | キョウチクトウ (@kyochikuto) it's by design from what the extension API does since it's setting a shellPath property not profile, it's not necessarily what the Python extension was going for.

Kartik Raj (@karrtikr) What is your take? From what I understand of Daniel Imms (@Tyriar) comments, Python-ext is more appropriate to implement this, correct?

[karrtikr]

I think this is by design because you're launching a shell, not a profile

I would expect the behavior of vscode.window.createTerminal() to be same as when clicking:

to open a new terminal. I think it was this way before the concept of terminal profiles got introduced.

Daniel Imms (@Tyriar) How do we launch such a terminal using vscode API?

[Tyriar]

Kartik Raj (@karrtikr) do you explicitly set the shellPath currently?