Fix some basic eslint errors in copilot

Starts working through some basic repo wide eslint rules for the copilot extension. Stuff like missing semicolons and missing readonly modifiers for disposables

Author: mjbvz

extensions/copilot/src/extension/chatSessions/copilotcli/node/permissionHelpers.ts

@@ -28,7 +28,7 @@ type CoreTerminalConfirmationToolParams = {
 		command: string | undefined;
 		isBackground: boolean;
 	};
-}
+};
 
 type CoreConfirmationToolParams = {
 	tool: ToolName.CoreConfirmationTool;
@@ -37,7 +37,7 @@ type CoreConfirmationToolParams = {
 		message: string;
 		confirmationType: 'basic';
 	};
-}
+};
 
 /**
  * The result of requesting permissions — the full union accepted by `Session.respondToPermission`.

extensions/copilot/src/extension/chatSessions/vscode-node/test/claudeChatSessionContentProvider.spec.ts

@@ -1202,6 +1202,7 @@ class FakeGitService extends mock<IGitService>() {
 	}
 
 	override dispose(): void {
+		super.dispose();
 		this._onDidOpenRepository.dispose();
 		this._onDidCloseRepository.dispose();
 	}

extensions/copilot/src/extension/completions-core/vscode-node/extension/src/codeReferencing/index.ts

@@ -21,7 +21,7 @@ export class CodeReference implements IDisposable {
 
 	constructor(
 		@IInstantiationService private readonly _instantiationService: IInstantiationService,
-		@ICompletionsRuntimeModeService readonly _runtimeMode: ICompletionsRuntimeModeService,
+		@ICompletionsRuntimeModeService private readonly _runtimeMode: ICompletionsRuntimeModeService,
 		@ICompletionsLogTargetService private readonly _logTarget: ICompletionsLogTargetService,
 		@IAuthenticationService private readonly _authenticationService: IAuthenticationService,
 	) { }

extensions/copilot/src/extension/completions-core/vscode-node/extension/src/statusBar.ts

@@ -21,8 +21,8 @@ export class CopilotStatusBar extends StatusReporter implements IDisposable {
 
 	constructor(
 		id: string,
-		@ICompletionsExtensionStatus readonly extensionStatusService: ICompletionsExtensionStatus,
-		@IInstantiationService readonly instantiationService: IInstantiationService,
+		@ICompletionsExtensionStatus private readonly extensionStatusService: ICompletionsExtensionStatus,
+		@IInstantiationService private readonly instantiationService: IInstantiationService,
 
 	) {
 		super();

extensions/copilot/src/extension/completions-core/vscode-node/lib/src/experiments/featuresService.ts

@@ -17,7 +17,7 @@ export type ContextProviderExpSettings = {
 	excludeRelatedFiles: boolean;
 	timeBudget: number;
 	params?: Record<string, string | boolean | number>;
-}
+};
 
 export const ICompletionsFeaturesService = createServiceIdentifier<ICompletionsFeaturesService>('ICompletionsFeaturesService');
 export interface ICompletionsFeaturesService {

extensions/copilot/src/extension/completions-core/vscode-node/lib/src/prompt/similarFiles/openTabFiles.ts

@@ -15,7 +15,9 @@ import {
 } from './neighborFiles';
 
 export class OpenTabFiles implements INeighborSource {
-	constructor(@ICompletionsTextDocumentManagerService readonly docManager: ICompletionsTextDocumentManagerService) { }
+	constructor(
+		@ICompletionsTextDocumentManagerService private readonly docManager: ICompletionsTextDocumentManagerService
+	) { }
 
 	private truncateDocs(
 		docs: readonly TextDocumentContents[],

extensions/copilot/src/extension/conversation/vscode-node/conversationFeature.ts

@@ -49,9 +49,9 @@ import { generateTerminalFixes, setLastCommandMatchResult } from './terminalFixG
  */
 export class ConversationFeature implements IExtensionContribution {
 	/** Disposables that exist for the lifetime of this object */
-	private _disposables = new DisposableStore();
+	private readonly _disposables = new DisposableStore();
 	/** Disposables that are cleared whenever feature enablement is toggled */
-	private _activatedDisposables = new DisposableStore();
+	private readonly _activatedDisposables = new DisposableStore();
 	/** For the conversation features to be enabled, the proxy needs to return a token with k/v pair: chat=1 */
 	public _enabled;
 	/** The feature is marked as active the first time it is enabled. */

extensions/copilot/src/extension/conversation/vscode-node/languageModelAccess.ts

@@ -486,7 +486,6 @@ class LanguageModelAccessPromptBaseCountCache {
 export class CopilotLanguageModelWrapper extends Disposable {
 
 	constructor(
-		@IExperimentationService readonly _expService: IExperimentationService,
 		@ITelemetryService private readonly _telemetryService: ITelemetryService,
 		@IBlockedExtensionService private readonly _blockedExtensionService: IBlockedExtensionService,
 		@IInstantiationService private readonly _instantiationService: IInstantiationService,

extensions/copilot/src/extension/conversation/vscode-node/remoteAgents.ts

@@ -88,7 +88,7 @@ interface IGitHubRepositoryReference {
 }
 
 export class RemoteAgentContribution implements IDisposable {
-	private disposables = new DisposableStore();
+	private readonly disposables = new DisposableStore();
 	private refreshRemoteAgentsP: Promise<void> | undefined;
 	private enabledSkillsPromise: Promise<Set<string>> | undefined;
 

extensions/copilot/src/extension/conversation/vscode-node/test/languageModelAccess.test.ts

@@ -29,7 +29,7 @@ suite('CopilotLanguageModelWrapper', () => {
 		instaService = accessor.get(IInstantiationService);
 	}
 
-	suite('validateRequest - invalid', async () => {
+	suite('validateRequest - invalid', () => {
 		let wrapper: CopilotLanguageModelWrapper;
 		let endpoint: IChatEndpoint;
 		setup(async () => {
@@ -59,7 +59,7 @@ suite('CopilotLanguageModelWrapper', () => {
 		});
 	});
 
-	suite('validateRequest - valid', async () => {
+	suite('validateRequest - valid', () => {
 		let wrapper: CopilotLanguageModelWrapper;
 		let endpoint: IChatEndpoint;
 		setup(async () => {