Skip to content

Commit 2b6f58f

Browse files
authored
Merge pull request #311483 from mjbvz/dev/mjbvz/new-mole
Remove empty dispose overrides
2 parents da62f68 + 442a051 commit 2b6f58f

File tree

13 files changed

+0
-44
lines changed

13 files changed

+0
-44
lines changed

src/vs/base/browser/ui/findinput/replaceInput.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,4 @@ export class ReplaceInput extends Widget {
280280
this.inputBox.paddingRight = this.cachedOptionsWidth;
281281
this.domNode.style.width = newWidth + 'px';
282282
}
283-
284-
public override dispose(): void {
285-
super.dispose();
286-
}
287283
}

src/vs/editor/browser/controller/mouseHandler.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -403,10 +403,6 @@ class MouseDownOperation extends Disposable {
403403
this._lastMouseEvent = null;
404404
}
405405

406-
public override dispose(): void {
407-
super.dispose();
408-
}
409-
410406
public isActive(): boolean {
411407
return this._isActive;
412408
}

src/vs/editor/browser/services/editorWorkerService.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,6 @@ export class EditorWorkerService extends Disposable implements IEditorWorkerServ
9797
this._register(languageFeaturesService.completionProvider.register('*', new WordBasedCompletionItemProvider(this._workerManager, configurationService, this._modelService, this._languageConfigurationService, this._logService, languageFeaturesService)));
9898
}
9999

100-
public override dispose(): void {
101-
super.dispose();
102-
}
103100

104101
public canComputeUnicodeHighlights(uri: URI): boolean {
105102
return canSyncModel(this._modelService, uri);

src/vs/editor/browser/viewParts/blockDecorations/blockDecorations.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ export class BlockDecorations extends ViewPart {
5151
return didChange;
5252
}
5353

54-
public override dispose(): void {
55-
super.dispose();
56-
}
5754

5855
// --- begin event handlers
5956

src/vs/editor/browser/viewParts/editorScrollbar/editorScrollbar.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,6 @@ export class EditorScrollbar extends ViewPart {
105105
this._register(dom.addDisposableListener(this.scrollbarDomNode.domNode, 'scroll', (e: Event) => onBrowserDesperateReveal(this.scrollbarDomNode.domNode, true, false)));
106106
}
107107

108-
public override dispose(): void {
109-
super.dispose();
110-
}
111108

112109
private _setLayout(): void {
113110
const options = this._context.configuration.options;

src/vs/editor/browser/viewParts/margin/margin.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ export class Margin extends ViewPart {
5050
this._domNode.appendChild(this._glyphMarginBackgroundDomNode);
5151
}
5252

53-
public override dispose(): void {
54-
super.dispose();
55-
}
5653

5754
public getDomNode(): FastDomNode<HTMLElement> {
5855
return this._domNode;

src/vs/editor/browser/viewParts/rulers/rulers.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ export class Rulers extends ViewPart {
3434
this._typicalHalfwidthCharacterWidth = options.get(EditorOption.fontInfo).typicalHalfwidthCharacterWidth;
3535
}
3636

37-
public override dispose(): void {
38-
super.dispose();
39-
}
4037

4138
// --- begin event handlers
4239

src/vs/editor/browser/viewParts/scrollDecoration/scrollDecoration.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,6 @@ export class ScrollDecorationViewPart extends ViewPart {
3535
this._domNode.setAttribute('aria-hidden', 'true');
3636
}
3737

38-
public override dispose(): void {
39-
super.dispose();
40-
}
4138

4239
private _updateShouldShow(): boolean {
4340
const newShouldShow = (this._useShadows && this._scrollTop > 0);

src/vs/editor/common/viewLayout/viewLayout.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,6 @@ export class ViewLayout extends Disposable implements IViewLayout {
191191
this._updateHeight();
192192
}
193193

194-
public override dispose(): void {
195-
super.dispose();
196-
}
197194

198195
public getScrollable(): Scrollable {
199196
return this._scrollable.getScrollable();

src/vs/editor/standalone/browser/standaloneCodeEditor.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -474,9 +474,6 @@ export class StandaloneEditor extends StandaloneCodeEditor implements IStandalon
474474
}
475475
}
476476

477-
public override dispose(): void {
478-
super.dispose();
479-
}
480477

481478
public override updateOptions(newOptions: Readonly<IEditorOptions & IGlobalEditorOptions>): void {
482479
updateConfigurationService(this._configurationService, newOptions, false);
@@ -544,9 +541,6 @@ export class StandaloneDiffEditor2 extends DiffEditorWidget implements IStandalo
544541
this._register(themeDomRegistration);
545542
}
546543

547-
public override dispose(): void {
548-
super.dispose();
549-
}
550544

551545
public override updateOptions(newOptions: Readonly<IDiffEditorOptions & IGlobalEditorOptions>): void {
552546
updateConfigurationService(this._configurationService, newOptions, true);

0 commit comments

Comments
 (0)