Skip to content

Commit 6ebb75a

Browse files
setup-volumes-agent.sh : Explain need for mount in comments
No code change, just 2 lines of comments pertaining to the seemingly redundant need to mount the folders when they *already* are under the discovery folder.
1 parent c4bf3f4 commit 6ebb75a

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

samples/features/sql-big-data-cluster/deployment/kubeadm/ubuntu/setup-volumes-agent.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,7 @@ for i in $(seq 1 $PV_COUNT); do
77
vol="vol$i"
88

99
mkdir -p /mnt/local-storage/$vol
10+
# If wondering why the next code line is needed, see https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/blob/master/docs/faqs.md#why-i-need-to-bind-mount-normal-directories-to-create-pvs-for-them
11+
# Experience showed that the mount need to exist at cluster provision time. The fact they're not put in fstab and will disappear after reboot doesn't seem to be an issue once the K8S PV are created.
1012
mount --bind /mnt/local-storage/$vol /mnt/local-storage/$vol
1113
done

0 commit comments

Comments
 (0)