Merge pull request #351 from microsoft/powershell-inline-expectationstests

Adding InlineExpectationsTests to Powershell

Author: MathiasVP

powershell/ql/lib/utils/test/InlineExpectationsTest.qll

@@ -0,0 +1,8 @@
+/**
+ * Inline expectation tests for Powershell.
+ * See `shared/util/codeql/util/test/InlineExpectationsTest.qll`
+ */
+
+private import codeql.util.test.InlineExpectationsTest
+private import internal.InlineExpectationsTestImpl
+import Make<Impl>

powershell/ql/lib/utils/test/InlineExpectationsTestQuery.ql

@@ -0,0 +1,21 @@
+/**
+ * @kind test-postprocess
+ */
+
+private import powershell
+private import codeql.util.test.InlineExpectationsTest as T
+private import internal.InlineExpectationsTestImpl
+import T::TestPostProcessing
+import T::TestPostProcessing::Make<Impl, Input>
+
+private module Input implements T::TestPostProcessing::InputSig<Impl> {
+  string getRelativeUrl(Location location) {
+    exists(File f, int startline, int startcolumn, int endline, int endcolumn |
+      location.hasLocationInfo(_, startline, startcolumn, endline, endcolumn) and
+      f = location.getFile()
+    |
+      result =
+        f.getRelativePath() + ":" + startline + ":" + startcolumn + ":" + endline + ":" + endcolumn
+    )
+  }
+}

powershell/ql/lib/utils/test/internal/InlineExpectationsTestImpl.qll

@@ -0,0 +1,13 @@
+private import powershell as P
+private import codeql.util.test.InlineExpectationsTest
+
+module Impl implements InlineExpectationsTestSig {
+  /**
+   * A class representing line comments in Powershell.
+   */
+  class ExpectationComment extends P::SingleLineComment {
+    string getContents() { result = this.getCommentContents().getValue().suffix(1) }
+  }
+
+  class Location = P::Location;
+}

powershell/ql/test/query-tests/security/ConvertToSecureStringAsPlainText/ConvertToSecureStringAsPlainText.qlref

@@ -1 +1,2 @@
-experimental/ConvertToSecureStringAsPlainText.ql
+query: experimental/ConvertToSecureStringAsPlainText.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

powershell/ql/test/query-tests/security/ConvertToSecureStringAsPlainText/test.ps1

@@ -1,4 +1,4 @@
 $UserInput = Read-Host 'Please enter your secure code'
-$EncryptedInput = ConvertTo-SecureString -String $UserInput -AsPlainText -Force
+$EncryptedInput = ConvertTo-SecureString -String $UserInput -AsPlainText -Force # $ Alert
 
 $SecureUserInput = Read-Host 'Please enter your secure code' -AsSecureString

powershell/ql/test/query-tests/security/HardcodedComputerName/HardcodedComputerName.qlref

@@ -1 +1,2 @@
-experimental/HardcodedComputerName.ql
+query: experimental/HardcodedComputerName.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

powershell/ql/test/query-tests/security/HardcodedComputerName/test.ps1

@@ -1,6 +1,6 @@
 Function Invoke-MyRemoteCommand ()
 {
-    Invoke-Command -Port 343 -ComputerName hardcoderemotehostname
+    Invoke-Command -Port 343 -ComputerName hardcoderemotehostname # $ Alert
 }
 
 Function Invoke-MyCommand ($ComputerName)
@@ -10,7 +10,7 @@ Function Invoke-MyCommand ($ComputerName)
 
 Function Invoke-MyLocalCommand ()
 {
-    Invoke-Command -Port 343 -ComputerName hardcodelocalhostname
+    Invoke-Command -Port 343 -ComputerName hardcodelocalhostname # $ Alert
 }
 
 Function Invoke-MyLocalCommand ()

powershell/ql/test/query-tests/security/UseOfReservedCmdletChar/UseOfReservedCmdletChar.qlref

@@ -1 +1,2 @@
-experimental/UseOfReservedCmdletChar.ql
+query: experimental/UseOfReservedCmdletChar.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

powershell/ql/test/query-tests/security/UseOfReservedCmdletChar/test.ps1

@@ -1,2 +1,2 @@
 function MyFunction[1]
-{...}
+{...} # $ Alert Alert

powershell/ql/test/query-tests/security/UsernameOrPasswordParameter/UsernameOrPasswordParameter.qlref

@@ -1 +1,2 @@
-experimental/UsernameOrPasswordParameter.ql
+query: experimental/UsernameOrPasswordParameter.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql