updated all powershell tests to use inline expectatoins

Author: chanel-y

powershell/ql/test/query-tests/security/ConvertToSecureStringAsPlainText/ConvertToSecureStringAsPlainText.qlref

@@ -1 +1,2 @@
-experimental/ConvertToSecureStringAsPlainText.ql
+query: experimental/ConvertToSecureStringAsPlainText.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

powershell/ql/test/query-tests/security/ConvertToSecureStringAsPlainText/test.ps1

@@ -1,4 +1,4 @@
 $UserInput = Read-Host 'Please enter your secure code'
-$EncryptedInput = ConvertTo-SecureString -String $UserInput -AsPlainText -Force
+$EncryptedInput = ConvertTo-SecureString -String $UserInput -AsPlainText -Force # $ Alert
 
 $SecureUserInput = Read-Host 'Please enter your secure code' -AsSecureString

powershell/ql/test/query-tests/security/HardcodedComputerName/HardcodedComputerName.qlref

@@ -1 +1,2 @@
-experimental/HardcodedComputerName.ql
+query: experimental/HardcodedComputerName.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

powershell/ql/test/query-tests/security/HardcodedComputerName/test.ps1

@@ -1,6 +1,6 @@
 Function Invoke-MyRemoteCommand ()
 {
-    Invoke-Command -Port 343 -ComputerName hardcoderemotehostname
+    Invoke-Command -Port 343 -ComputerName hardcoderemotehostname # $ Alert
 }
 
 Function Invoke-MyCommand ($ComputerName)
@@ -10,7 +10,7 @@ Function Invoke-MyCommand ($ComputerName)
 
 Function Invoke-MyLocalCommand ()
 {
-    Invoke-Command -Port 343 -ComputerName hardcodelocalhostname
+    Invoke-Command -Port 343 -ComputerName hardcodelocalhostname # $ Alert
 }
 
 Function Invoke-MyLocalCommand ()

powershell/ql/test/query-tests/security/UseOfReservedCmdletChar/UseOfReservedCmdletChar.qlref

@@ -1 +1,2 @@
-experimental/UseOfReservedCmdletChar.ql
+query: experimental/UseOfReservedCmdletChar.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

powershell/ql/test/query-tests/security/UseOfReservedCmdletChar/test.ps1

@@ -1,2 +1,2 @@
-function MyFunction[1]
+function MyFunction[1] # $ Alert Alert
 {...}

powershell/ql/test/query-tests/security/UsernameOrPasswordParameter/UsernameOrPasswordParameter.qlref

@@ -1 +1,2 @@
-experimental/UsernameOrPasswordParameter.ql
+query: experimental/UsernameOrPasswordParameter.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

powershell/ql/test/query-tests/security/UsernameOrPasswordParameter/test.ps1

@@ -4,8 +4,8 @@ function Test-Script
     Param
     (
         [String]
-        $Username,
+        $Username, # $ Alert
         [SecureString]
-        $Password
+        $Password # $ Alert
     )
 }

powershell/ql/test/query-tests/security/cwe-022/test.ps1

@@ -3,27 +3,27 @@ Add-Type -AssemblyName System.IO.Compression.FileSystem
 $zip = [System.IO.Compression.ZipFile]::OpenRead("MyPath\to\archive.zip")
 
 foreach ($entry in $zip.Entries) {
-    $targetPath = Join-Path $extractPath $entry.FullName
+    $targetPath = Join-Path $extractPath $entry.FullName # $ Source
     $fullTargetPath = [System.IO.Path]::GetFullPath($targetPath)
 
-    [System.IO.Compression.ZipFileExtensions]::ExtractToFile($entry, $fullTargetPath) # BAD
+    [System.IO.Compression.ZipFileExtensions]::ExtractToFile($entry, $fullTargetPath) # $ Alert
 }
 
 foreach ($entry in $zip.Entries) {
-    $targetPath = Join-Path $extractPath $entry.FullName
+    $targetPath = Join-Path $extractPath $entry.FullName # $ Source
     $fullTargetPath = [System.IO.Path]::GetFullPath($targetPath)
 
-    $stream = [System.IO.File]::Open($fullTargetPath, 'Create') # BAD
+    $stream = [System.IO.File]::Open($fullTargetPath, 'Create') # $ Alert
     $entry.Open().CopyTo($stream)
     $stream.Close()
 }
 
 foreach ($entry in $zip.Entries) {
-    $targetPath = Join-Path $extractPath $entry.FullName
+    $targetPath = Join-Path $extractPath $entry.FullName # $ Source
     $fullTargetPath = [System.IO.Path]::GetFullPath($targetPath)
 
     $extractRoot = [System.IO.Path]::GetFullPath($extractPath)
     if ($fullTargetPath.StartsWith($extractRoot)) {
-        [System.IO.Compression.ZipFileExtensions]::ExtractToFile($entry, $fullTargetPath) # GOOD [FALSE POSITIVE]
+        [System.IO.Compression.ZipFileExtensions]::ExtractToFile($entry, $fullTargetPath) # $ Alert
     }
 }

powershell/ql/test/query-tests/security/cwe-022/zipslip.qlref

@@ -1 +1,2 @@
-queries/security/cwe-022/ZipSlip.ql
+query: queries/security/cwe-022/ZipSlip.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql